Skip to content

Commit 64843bc

Browse files
ci: clarify merge-queue mint-failure is fail-closed (review r3654295072)
Soften the overstated 'the mint always succeeds here' comment and document the mint-failure case explicitly: it is uncloseable in-workflow (only the pinned app can post to the pinned context; a github.token fallback lands on a different context and neither satisfies nor fails the gate), but it is fail-CLOSED — the merge queue's check_response_timeout evicts an entry whose required check never reports, and the mint failure shows as a red run. No code change; comment only. Co-authored-by: Isaac
1 parent d2eeea1 commit 64843bc

1 file changed

Lines changed: 12 additions & 1 deletion

File tree

.github/workflows/trigger-integration-tests.yml

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -346,7 +346,18 @@ jobs:
346346
# dispatch-failure — must be attributed to the same app, or it lands on a
347347
# different check context and never satisfies the pinned gate (leaving the
348348
# merge queue stuck). merge_group runs on the base repo with full secret
349-
# access, so the mint always succeeds here.
349+
# access, so the mint normally succeeds here.
350+
#
351+
# If the mint ITSELF fails (secret rotation, app uninstall, transient
352+
# create-github-app-token error) the job aborts before it can post any
353+
# check. That case is uncloseable in-workflow — only this app can post to
354+
# the app-pinned context, so no fallback identity (github.token included)
355+
# can substitute; a same-named github.token check lands on a DIFFERENT
356+
# context and neither satisfies nor fails the gate. It is fail-CLOSED, not a
357+
# bypass: the merge queue's check_response_timeout evicts an entry whose
358+
# required check never reports (it does not merge), and a mint failure also
359+
# surfaces as a red workflow run. Mitigation is out-of-band (alerting on the
360+
# token-mint step), not another in-workflow check.
350361
- name: Generate GitHub App Token (internal repo)
351362
id: app-token
352363
uses: actions/create-github-app-token@f8d387b68d61c58ab83c6c016672934102569859 # v3.0.0

0 commit comments

Comments
 (0)