ai: apply changes for #876 (2 review threads)

Addresses:
  - #3635989590 at src/databricks/sql/auth/oauth.py:74
  - #3635989594 at tests/unit/test_auth.py:254

Signed-off-by: peco-engineer-bot[bot] <peco-engineer-bot[bot]@users.noreply.github.com>

Author: peco-engineer-bot[bot]

src/databricks/sql/auth/oauth.py

@@ -206,9 +206,11 @@ def _on_timeout():
                 msg = (
                     f"Timed out after {self._redirect_callback_timeout_seconds} "
                     f"seconds waiting for the OAuth redirect callback at "
-                    f"{redirect_url}. No browser completed the login flow — this "
-                    "is expected in a headless environment (e.g. a notebook or "
-                    "job with no browser). See issue #458."
+                    f"{redirect_url}. The login flow was not completed in time — "
+                    "either the interactive login was not finished within the "
+                    "timeout, or this is a headless environment (e.g. a notebook "
+                    "or job with no browser) where no browser can complete the "
+                    "flow. See issue #458."
                 )
             else:
                 msg = f"No path parameters were returned to the callback at {redirect_url}"

tests/unit/test_auth.py

@@ -227,15 +227,18 @@ def test_get_tokens_does_not_hang_when_no_callback_received(
         # the test does not depend on a specific port being free. A fixed port
         # that happens to be occupied would fail to bind and take the
         # can't-find-free-port branch instead of the timeout path we exercise.
+        # Keep the test fast: shorten the callback wait via the constructor
+        # keyword (the actual new surface this PR introduces) rather than
+        # mutating the private attribute after the fact. This also exercises the
+        # Optional[int] fall-back logic. The production default is minutes; the
+        # bug is that WITHOUT any bound the wait is infinite.
         oauth_manager = OAuthManager(
             port_range=[0],
             client_id="mock-id",
             idp_endpoint=InHouseOAuthEndpointCollection(),
             http_client=MagicMock(),
+            redirect_callback_timeout_seconds=2,
         )
-        # Keep the test fast: shorten the callback wait. The production default
-        # is minutes; the bug is that WITHOUT any bound the wait is infinite.
-        oauth_manager._redirect_callback_timeout_seconds = 2
 
         # No callback is ever delivered to the redirect server. Run the flow in
         # a daemon thread and join with a wall-clock bound so a regression to