Skip to content

Commit a3020af

Browse files
ai: apply changes for #882 (1 review thread)
Addresses: - #3654123624 at .github/workflows/engineer-bot-learning.yml:75 Signed-off-by: peco-engineer-bot[bot] <peco-engineer-bot[bot]@users.noreply.github.com>
1 parent a440a7b commit a3020af

1 file changed

Lines changed: 7 additions & 7 deletions

File tree

.github/workflows/engineer-bot-learning.yml

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -68,13 +68,13 @@ jobs:
6868
fetch-depth: 0
6969
persist-credentials: false
7070

71-
# Route pip through the JFrog proxy for the engine install (the retrospective
72-
# reads diffs via the API; it doesn't build/run the connector, so no poetry
73-
# deps needed — just a Python interpreter + the engine). MUST run before
74-
# bot-prelude (install-bot-engine reuses its PIP_INDEX_URL / JFROG_ACCESS_TOKEN).
75-
- name: Set up JFrog (pip)
76-
uses: ./.github/actions/setup-jfrog
77-
71+
# No JFrog setup step here: install-bot-engine (via bot-prelude) does its own
72+
# keyless OIDC→JFrog mint and passes the credential through job-local files +
73+
# per-command --index-url flags. It deliberately never reads PIP_INDEX_URL /
74+
# JFROG_ACCESS_TOKEN from the environment, so a setup-jfrog step would be both
75+
# redundant AND a credential leak (setup-jfrog exports a token-bearing
76+
# PIP_INDEX_URL to $GITHUB_ENV, exposing it to every later step — including the
77+
# one that runs the model). Mirrors the read-only sibling reviewer-bot.yml.
7878
- name: Setup Python
7979
uses: actions/setup-python@ece7cb06caefa5fff74198d8649806c4678c61a1 # v6.3.0
8080
with:

0 commit comments

Comments
 (0)