Skip to content

Commit 5cd4ed8

Browse files
committed
Hack to address CI flakiness.
1 parent e06e7a7 commit 5cd4ed8

1 file changed

Lines changed: 11 additions & 0 deletions

File tree

sjsonnet/test/src-jvm/sjsonnet/ErrorTestsJvmOnly.scala

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,17 @@ object ErrorTestsJvmOnly extends TestSuite {
2222
}
2323

2424
val tests: Tests = Tests {
25+
// Hack: this test suite may flakily fail if this suite runs prior to other error tests:
26+
// if classloading or linking happens inside the StackOverflowError handling then that
27+
// may will trigger a secondary StackOverflowError and cause the test to fail.
28+
// As a temporary solution, we redundantly run one of the other error tests first.
29+
// A better long term solution would be to change how we handle StackOverflowError
30+
// to avoid this failure mode, but for now we add this hack to avoid CI flakiness:
31+
test("02") - check(
32+
"""sjsonnet.Error: Foo.
33+
| at [Error].(sjsonnet/test/resources/test_suite/error.02.jsonnet:17:1)
34+
|""".stripMargin
35+
)
2536
test("array_recursive_manifest") - check(
2637
"""sjsonnet.Error: Stackoverflow while materializing, possibly due to recursive value
2738
| at .(sjsonnet/test/resources/test_suite/error.array_recursive_manifest.jsonnet:17:12)

0 commit comments

Comments
 (0)