Use simplified state.report

Author: hermansje

shellwhat/checks/has_funcs.py

@@ -65,7 +65,7 @@ def has_code(
 
     if not res:
         _msg = state.build_message(incorrect_msg, fmt_kwargs={"text": text})
-        state.report(Feedback(_msg))
+        state.report(_msg)
 
     return state
 
@@ -122,7 +122,7 @@ def has_output(
         _msg = state.build_message(
             incorrect_msg, fmt_kwargs={"text": text, "fixed": fixed}
         )
-        state.report(Feedback(_msg))
+        state.report(_msg)
 
     return state
 
@@ -188,7 +188,7 @@ def has_expr(
         _msg = state.build_message(
             incorrect_msg, fmt_kwargs={"expr": expr, "output": output}
         )
-        state.report(Feedback(_msg))
+        state.report(_msg)
 
     return state
 

tests/test_selectors.py

@@ -36,7 +36,7 @@ def d():
 
 @pytest.fixture("function")
 def shell_script():
-    return """# Use curl, download file from URL and rename 
+    return """# Use curl, download file from URL and rename
 curl -o Spotify201812.zip -L https://tinyurl.com/Zipped201812Spotify
 
 # Unzip file then delete original zipped file
@@ -111,11 +111,7 @@ def test_osh_selector_high_priority(self, state):
         assert isinstance(child.student_ast, target)
         assert child.student_ast.token.val == "c"
         with pytest.raises(TF):
-            from protowhat.Feedback import Feedback
-
-            fb = Feedback("test")
-            child.report(fb)
-            assert fb.highlight is not None
+            child.report("test")
 
     def test_osh_selector_fail(self, state):
         with pytest.raises(TF):