PyFlakes compliance and testing

Author: palewire

.travis.yml

@@ -7,6 +7,7 @@ install:
 - pip install -r requirements.txt --use-mirrors
 script:
  - pep8 documentcloud
+ - pyflakes documentcloud
  - python test.py
 env:
   global:

documentcloud/MultipartPostHandler.py

@@ -39,14 +39,13 @@
   The main function of this file is a sample which downloads a page and
   then uploads it to the W3C validator.
 """
+import os
 import sys
-import tempfile
 import urllib
 import urllib2
+import tempfile
 import mimetools
 import mimetypes
-import os
-import stat
 from os import SEEK_END
 from cStringIO import StringIO
 
@@ -106,7 +105,6 @@ def multipart_encode(vars, files, boundary=None, buf=None):
             buf.write('Content-Disposition: form-data; name="%s"' % key)
             buf.write('\r\n\r\n' + value + '\r\n')
         for(key, fd) in files:
-            file_size = getsize(fd)
             try:
                 filename = fd.name.split('/')[-1]
             except AttributeError:
@@ -143,17 +141,11 @@ def getsize(o_file):
 
 
 def main():
-    validatorURL = "http://validator.w3.org/check"
     opener = urllib2.build_opener(MultipartPostHandler)
 
     def validateFile(url):
         temp = tempfile.mkstemp(suffix=".html")
         os.write(temp[0], opener.open(url).read())
-        params = {
-            "ss": "0",  # show source
-            "doctype": "Inline",
-            "uploaded_file": open(temp[1], "rb")
-        }
         os.remove(temp[1])
 
     if len(sys.argv[1:]) > 0:

documentcloud/__init__.py

@@ -16,8 +16,11 @@
 import base64
 import urllib
 import urllib2
-from datetime import datetime
-from toolbox import *
+from toolbox import retry
+from toolbox import DoesNotExistError
+from toolbox import DuplicateObjectError
+from toolbox import credentials_required
+from toolbox import CredentialsFailedError
 from dateutil.parser import parse as dateparser
 from MultipartPostHandler import MultipartPostHandler
 try:
@@ -115,7 +118,7 @@ def put(self, method, params):
             # Otherwise, we can just use the vanilla urllib prep method
             params = urllib.urlencode(params, doseq=True)
         # Make the request
-        content = self._make_request(
+        self._make_request(
             self.BASE_URI + method,
             params,
         )
@@ -320,7 +323,7 @@ def delete(self, id):
         """
         Deletes a Document.
         """
-        data = self.fetch(
+        self.fetch(
             'documents/%s.json' % id,
             {'_method': 'delete'},
         )
@@ -462,7 +465,7 @@ def delete(self, id):
         """
         Deletes a Project.
         """
-        data = self.fetch(
+        self.fetch(
             'projects/%s.json' % id,
             {'_method': 'delete'},
         )

documentcloud/toolbox.py

@@ -73,7 +73,7 @@ def f_retry(*args, **kwargs):
                     return f(*args, **kwargs)
                     try_one_last_time = False
                     break
-                except ExceptionToCheck, e:
+                except ExceptionToCheck:
                     print "Retrying in %s seconds" % str(mdelay)
                     time.sleep(mdelay)
                     mtries -= 1