Skip to content

Commit 57de79f

Browse files
committed
added PR template
1 parent 4305357 commit 57de79f

1 file changed

Lines changed: 20 additions & 0 deletions

File tree

PULL_REQUEST_TEMPLATE.md

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
1+
## Instructions & checklist for PR author
2+
3+
### Description of changes
4+
[Add descriptions of changes made]
5+
6+
### Refactor instructions
7+
- [ ] Replaced `x <- eval(parse(text = x.name), envir = parent.frame())` with `x <- .loadServersideObject(x)`
8+
- [ ] If necessary, check the class of the object using `.checkClass()`
9+
10+
### Testing instructions
11+
- [ ] Writen server-side unit tests for unhappy flow
12+
- [ ] Run `devtools::test(filter = "smk-|disc|arg")` and check it passes
13+
- [ ] Run `devtools::check(args = '--no-tests')` and check it passes (we run tests separately to skip performance checks)
14+
- [ ] Run `devtools::build()` and check it builds without errors
15+
16+
## Instructions & checklist for PR reviewers
17+
- [ ] Run `devtools::test(filter = "smk-|disc|arg")` and check it passes
18+
- [ ] Run `devtools::check(args = '--no-tests')` and check it passes (we run tests separately to skip performance checks)
19+
- [ ] Run `devtools::build()` and check it builds without errors
20+

0 commit comments

Comments
 (0)