Mistake in mergeDS?

[timcadman]

I'm currently working on the refactor, and noticed the following in mergeDS:

output <- merge(x=x.data.frame, y=y.data.frame, by=NULL,
      by.x = by.x.colnames, by.y = by.x.colnames, all=FALSE, all.x = all.x, all.y = all.y,
      sort = sort, suffixes = suffixes.character.vector, no.dups = no.dups,
      incomparables = incomparables)

Is this right? Or should it read by.y = by.y.colnames?

[davraam]

yes it should be by.y = by.y.colnames