Skip to content

Commit 5975328

Browse files
committed
[review][s]Comments cleanup and file name changes
1 parent f0d9e46 commit 5975328

4 files changed

Lines changed: 1 addition & 13 deletions

File tree

app.js

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ require('dotenv').config()
33
var createError = require('http-errors')
44
var express = require('express')
55
var cors = require('cors')
6-
// var path = require('path')
76
var cookieParser = require('cookie-parser')
87
var logger = require('morgan')
98
var proxy = require('express-http-proxy')
@@ -18,8 +17,6 @@ app.use(logger('dev'))
1817
app.use(express.json())
1918
app.use(express.urlencoded({ extended: false }))
2019
app.use(cookieParser())
21-
// No need for static dir for now as we're building an API only app
22-
// app.use(express.static(path.join(__dirname, 'public')));
2320

2421
app.use('/', indexRouter)
2522

routes/index.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,6 @@ const APP_VERSION = 'v1'
1313

1414
/* Gets the schema from a GraphQL*/
1515
async function getGraphQLTableSchema(resource_id) {
16-
// console.log("ResourceID: " + resource_id)
17-
1816
const queryForSchema = gql`
1917
{
2018
__type(name: "${resource_id}") {

test/test-download.html

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,4 @@
11
<pre>
2-
3-
4-
5-
62
<h3>Manual download file from query test</h3>:
73

84
<button id="b-json" download="dwnl.json">JSON</button>
@@ -54,11 +50,8 @@ <h3>Manual download file from query test</h3>:
5450
link.download = filename;
5551

5652
document.body.appendChild(link);
57-
5853
link.click();
59-
6054
document.body.removeChild(link);
61-
6255
return response.body
6356
} catch(err) {
6457
console.error(`Error: ${err}`)
@@ -67,7 +60,7 @@ <h3>Manual download file from query test</h3>:
6760

6861
document.getElementById('b-json').addEventListener('click', async _ => createListener('/v1/download'))
6962
document.getElementById('b-csv').addEventListener('click', async _ => createListener('/v1/download?format=csv'))
70-
document.getElementById('b-tsv').addEventListener('click', async _ => createListener('/v1/download?format=csv&field_separator=%09'))
63+
document.getElementById('b-tsv').addEventListener('click', async _ => createListener('/v1/download?format=tsv'))
7164
document.getElementById('b-xlsx').addEventListener('click', async _ => createListener('/v1/download?format=xlsx'))
7265

7366
document.getElementById('json').value = QUERY

0 commit comments

Comments
 (0)