Skip to content

Commit 74b6005

Browse files
authored
Merge pull request #29 from datopian/feature/dev-readme
[readme][s]: clarifies development setup.
2 parents 8c7fe4d + 04e24dc commit 74b6005

1 file changed

Lines changed: 18 additions & 8 deletions

File tree

README.md

Lines changed: 18 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -80,17 +80,15 @@ We can make different queries:
8080

8181
## Contributing
8282

83-
### Local development environment
84-
85-
1. launch bg services (postgres + hasura) (`bash run-mock-environment.sh`)
86-
2. `cp .env.example .env`
87-
3. `yarn`
83+
1. copy env variables - `cp .env.example .env`
84+
2. set up background services - this repo contains a mock environment you can launch with `bash run-mock-environment.sh` or if connecting to an existing one edit the URLs in the `.env` file
85+
3. install dependencies - `yarn`
8886
4. `yarn start` to launch server / `yarn test` to run tests
89-
5. install and use prettier to format code - https://prettier.io/docs/en/install.html (otherwise new builds will likely fail)
87+
5. setup automatic code formatter - install and use [prettier](https://prettier.io/docs/en/install.html), if using vscode install [prettier-vscode extention](https://marketplace.visualstudio.com/items?itemName=esbenp.prettier-vscode)
9088

9189
Please don't forget to add new variables to `.env.example` - they also will be used in ci tests.
9290

93-
### CI
91+
### GitHub CI
9492

9593
#### Tests
9694

@@ -106,4 +104,16 @@ You will need to navigate there:
106104

107105
#### Docker image builds
108106

109-
After every push to master and successful tests there is a new docker image built here https://hub.docker.com/repository/docker/datopian/data-api/builds
107+
After every push to [master](https://github.com/datopian/data-api/tree/master) or a pull request to this branch and successful tests there is a new docker image built here https://hub.docker.com/repository/docker/datopian/data-api/builds
108+
109+
## Building
110+
111+
New images can be build with the provided [Dockerfile](./Dockerfile) or fetched from [dockerhub](https://hub.docker.com/repository/docker/datopian/data-api).
112+
113+
## Deployment
114+
115+
Can be deployed as a usual docker container. An environement for this microservice should contain:
116+
117+
1. postgres database
118+
2. hasura
119+
3. environment variables (see [.env.example](/.env.example))

0 commit comments

Comments
 (0)