Skip to content

Commit 1e62339

Browse files
authored
fix: remove pnpm cache from bump-npm-version (#60)
## Summary `bump-npm-version.yaml` never runs `pnpm install`, so `setup-node` with `cache: pnpm` fails at teardown because the cache directory doesn't exist: ``` Path Validation Error: Path(s) specified in the action for caching do(es) not exist, hence no cache is being saved. ``` This caused the `Post Setup Node.js` step to fail in datum-cloud/activity#160. ## Changes - Remove `pnpm/action-setup` step — not needed when there's no install - Remove `cache: pnpm` and `cache-dependency-path` from `setup-node` — same reason - Remove `lockfile-path` input — only existed to support pnpm caching The workflow only needs Node.js to read `package.json` (version resolution) and run `npm version` (bump + tag). ## Test plan - [ ] Merge and tag `v1.13.1` - [ ] Re-run the failing workflow in datum-cloud/activity — `Post Setup Node.js` should no longer fail
2 parents 82f8b37 + c38b2f4 commit 1e62339

1 file changed

Lines changed: 0 additions & 15 deletions

File tree

.github/workflows/bump-npm-version.yaml

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -20,14 +20,6 @@ on:
2020
type: number
2121
description: "Node.js version to use"
2222
default: 24
23-
lockfile-path:
24-
required: false
25-
type: string
26-
description: >
27-
Path to pnpm-lock.yaml relative to the repo root.
28-
Defaults to "<package-path>/pnpm-lock.yaml".
29-
Set to "pnpm-lock.yaml" for monorepos with a root lockfile.
30-
default: ""
3123
outputs:
3224
new-version:
3325
description: "The new version after bumping (e.g. `v1.3.0`)"
@@ -48,17 +40,10 @@ jobs:
4840
with:
4941
ref: main
5042

51-
- name: Setup pnpm
52-
uses: pnpm/action-setup@v4
53-
with:
54-
package_json_file: ${{ inputs.package-path }}/package.json
55-
5643
- name: Setup Node.js
5744
uses: actions/setup-node@v4
5845
with:
5946
node-version: ${{ inputs.node-version }}
60-
cache: pnpm
61-
cache-dependency-path: ${{ inputs.lockfile-path || format('{0}/pnpm-lock.yaml', inputs.package-path) }}
6247

6348
- name: Resolve new version
6449
id: resolve-version

0 commit comments

Comments
 (0)