feat: use forEach for status conditions

Replace verbose per-condition CEL filter/exists logic with the new
forEach field on metric specs. Each status-condition generator now
iterates object.status.conditions once and emits one series per
element via item.*, rather than hardcoding individual condition types.

The quota-grant-creation-policy generator previously had two separate
metrics (Ready + ParentContextReady); these are collapsed into a single
forEach metric.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: scotwells

config/resource-metrics-policies/milo-metrics.yaml

@@ -158,25 +158,19 @@ spec:
           help: "Status conditions for IAM policy bindings"
           type: gauge
           metrics:
-            - value: |
-                object.status.conditions.exists(c, c.type == 'Ready') ?
-                  (object.status.conditions.filter(c, c.type == 'Ready')[0].status == 'True' ? 1.0 : 0.0) :
-                  0.0
+            - forEach: "object.status.conditions"
+              value: "item.status == 'True' ? 1.0 : 0.0"
               labels:
                 - name: name
                   value: "object.metadata.name"
                 - name: namespace
                   value: "object.metadata.namespace"
                 - name: condition
-                  value: "'Ready'"
+                  value: "item.type"
                 - name: reason
-                  value: |
-                    object.status.conditions.exists(c, c.type == 'Ready') ?
-                      object.status.conditions.filter(c, c.type == 'Ready')[0].reason : ''
+                  value: "item.reason"
                 - name: status
-                  value: |
-                    object.status.conditions.exists(c, c.type == 'Ready') ?
-                      object.status.conditions.filter(c, c.type == 'Ready')[0].status : ''
+                  value: "item.status"
 
     # iam.miloapis.com: ProtectedResource
     - name: iam-protected-resources-info
@@ -224,25 +218,19 @@ spec:
           help: "Status conditions for IAM protected resources"
           type: gauge
           metrics:
-            - value: |
-                object.status.conditions.exists(c, c.type == 'Ready') ?
-                  (object.status.conditions.filter(c, c.type == 'Ready')[0].status == 'True' ? 1.0 : 0.0) :
-                  0.0
+            - forEach: "object.status.conditions"
+              value: "item.status == 'True' ? 1.0 : 0.0"
               labels:
                 - name: name
                   value: "object.metadata.name"
                 - name: namespace
                   value: "object.metadata.namespace"
                 - name: condition
-                  value: "'Ready'"
+                  value: "item.type"
                 - name: reason
-                  value: |
-                    object.status.conditions.exists(c, c.type == 'Ready') ?
-                      object.status.conditions.filter(c, c.type == 'Ready')[0].reason : ''
+                  value: "item.reason"
                 - name: status
-                  value: |
-                    object.status.conditions.exists(c, c.type == 'Ready') ?
-                      object.status.conditions.filter(c, c.type == 'Ready')[0].status : ''
+                  value: "item.status"
 
     # iam.miloapis.com: Role
     - name: iam-roles-info
@@ -290,25 +278,19 @@ spec:
           help: "Status conditions for IAM roles"
           type: gauge
           metrics:
-            - value: |
-                object.status.conditions.exists(c, c.type == 'Ready') ?
-                  (object.status.conditions.filter(c, c.type == 'Ready')[0].status == 'True' ? 1.0 : 0.0) :
-                  0.0
+            - forEach: "object.status.conditions"
+              value: "item.status == 'True' ? 1.0 : 0.0"
               labels:
                 - name: name
                   value: "object.metadata.name"
                 - name: namespace
                   value: "object.metadata.namespace"
                 - name: condition
-                  value: "'Ready'"
+                  value: "item.type"
                 - name: reason
-                  value: |
-                    object.status.conditions.exists(c, c.type == 'Ready') ?
-                      object.status.conditions.filter(c, c.type == 'Ready')[0].reason : ''
+                  value: "item.reason"
                 - name: status
-                  value: |
-                    object.status.conditions.exists(c, c.type == 'Ready') ?
-                      object.status.conditions.filter(c, c.type == 'Ready')[0].status : ''
+                  value: "item.status"
 
     # iam.miloapis.com: UserInvitation
     - name: iam-user-invitations-info
@@ -502,25 +484,19 @@ spec:
           help: "Status conditions for resource manager organization memberships"
           type: gauge
           metrics:
-            - value: |
-                object.status.conditions.exists(c, c.type == 'Ready') ?
-                  (object.status.conditions.filter(c, c.type == 'Ready')[0].status == 'True' ? 1.0 : 0.0) :
-                  0.0
+            - forEach: "object.status.conditions"
+              value: "item.status == 'True' ? 1.0 : 0.0"
               labels:
                 - name: name
                   value: "object.metadata.name"
                 - name: namespace
                   value: "object.metadata.namespace"
                 - name: condition
-                  value: "'Ready'"
+                  value: "item.type"
                 - name: reason
-                  value: |
-                    object.status.conditions.exists(c, c.type == 'Ready') ?
-                      object.status.conditions.filter(c, c.type == 'Ready')[0].reason : ''
+                  value: "item.reason"
                 - name: status
-                  value: |
-                    object.status.conditions.exists(c, c.type == 'Ready') ?
-                      object.status.conditions.filter(c, c.type == 'Ready')[0].status : ''
+                  value: "item.status"
 
     # resourcemanager.miloapis.com: Organization
     - name: resourcemanager-organizations-info
@@ -570,25 +546,19 @@ spec:
           help: "Status conditions for resource manager organizations"
           type: gauge
           metrics:
-            - value: |
-                object.status.conditions.exists(c, c.type == 'Ready') ?
-                  (object.status.conditions.filter(c, c.type == 'Ready')[0].status == 'True' ? 1.0 : 0.0) :
-                  0.0
+            - forEach: "object.status.conditions"
+              value: "item.status == 'True' ? 1.0 : 0.0"
               labels:
                 - name: name
                   value: "object.metadata.name"
                 - name: namespace
                   value: "object.metadata.namespace"
                 - name: condition
-                  value: "'Ready'"
+                  value: "item.type"
                 - name: reason
-                  value: |
-                    object.status.conditions.exists(c, c.type == 'Ready') ?
-                      object.status.conditions.filter(c, c.type == 'Ready')[0].reason : ''
+                  value: "item.reason"
                 - name: status
-                  value: |
-                    object.status.conditions.exists(c, c.type == 'Ready') ?
-                      object.status.conditions.filter(c, c.type == 'Ready')[0].status : ''
+                  value: "item.status"
 
     # resourcemanager.miloapis.com: Project
     - name: resourcemanager-projects-info
@@ -640,22 +610,16 @@ spec:
           help: "Status conditions for resource manager projects"
           type: gauge
           metrics:
-            - value: |
-                object.status.conditions.exists(c, c.type == 'Ready') ?
-                  (object.status.conditions.filter(c, c.type == 'Ready')[0].status == 'True' ? 1.0 : 0.0) :
-                  0.0
+            - forEach: "object.status.conditions"
+              value: "item.status == 'True' ? 1.0 : 0.0"
               labels:
                 - name: name
                   value: "object.metadata.name"
                 - name: namespace
                   value: "object.metadata.namespace"
                 - name: condition
-                  value: "'Ready'"
+                  value: "item.type"
                 - name: reason
-                  value: |
-                    object.status.conditions.exists(c, c.type == 'Ready') ?
-                      object.status.conditions.filter(c, c.type == 'Ready')[0].reason : ''
+                  value: "item.reason"
                 - name: status
-                  value: |
-                    object.status.conditions.exists(c, c.type == 'Ready') ?
-                      object.status.conditions.filter(c, c.type == 'Ready')[0].status : ''
+                  value: "item.status"

config/resource-metrics-policies/milo-quota-metrics.yaml

@@ -202,23 +202,17 @@ spec:
           help: "Status conditions for quota claim creation policies"
           type: gauge
           metrics:
-            - value: |
-                object.status.conditions.exists(c, c.type == 'Ready') ?
-                  (object.status.conditions.filter(c, c.type == 'Ready')[0].status == 'True' ? 1.0 : 0.0) :
-                  0.0
+            - forEach: "object.status.conditions"
+              value: "item.status == 'True' ? 1.0 : 0.0"
               labels:
                 - name: name
                   value: "object.metadata.name"
                 - name: condition
-                  value: "'Ready'"
+                  value: "item.type"
                 - name: reason
-                  value: |
-                    object.status.conditions.exists(c, c.type == 'Ready') ?
-                      object.status.conditions.filter(c, c.type == 'Ready')[0].reason : ''
+                  value: "item.reason"
                 - name: status
-                  value: |
-                    object.status.conditions.exists(c, c.type == 'Ready') ?
-                      object.status.conditions.filter(c, c.type == 'Ready')[0].status : ''
+                  value: "item.status"
 
     - name: quota-claim-creation-policy-enabled
       resource:
@@ -292,7 +286,7 @@ spec:
                 - name: parent_context_kind
                   value: "has(object.spec.target) && has(object.spec.target.parentContext) ? object.spec.target.parentContext.kind : ''"
 
-    - name: quota-grant-creation-policy-status-condition-ready
+    - name: quota-grant-creation-policy-status-condition
       resource:
         group: quota.miloapis.com
         version: v1alpha1
@@ -302,40 +296,17 @@ spec:
           help: "Status conditions for quota grant creation policies"
           type: gauge
           metrics:
-            - value: |
-                object.status.conditions.exists(c, c.type == 'Ready') ?
-                  (object.status.conditions.filter(c, c.type == 'Ready')[0].status == 'True' ? 1.0 : 0.0) :
-                  0.0
-              labels:
-                - name: name
-                  value: "object.metadata.name"
-                - name: condition
-                  value: "'Ready'"
-                - name: reason
-                  value: |
-                    object.status.conditions.exists(c, c.type == 'Ready') ?
-                      object.status.conditions.filter(c, c.type == 'Ready')[0].reason : ''
-                - name: status
-                  value: |
-                    object.status.conditions.exists(c, c.type == 'Ready') ?
-                      object.status.conditions.filter(c, c.type == 'Ready')[0].status : ''
-            - value: |
-                object.status.conditions.exists(c, c.type == 'ParentContextReady') ?
-                  (object.status.conditions.filter(c, c.type == 'ParentContextReady')[0].status == 'True' ? 1.0 : 0.0) :
-                  0.0
+            - forEach: "object.status.conditions"
+              value: "item.status == 'True' ? 1.0 : 0.0"
               labels:
                 - name: name
                   value: "object.metadata.name"
                 - name: condition
-                  value: "'ParentContextReady'"
+                  value: "item.type"
                 - name: reason
-                  value: |
-                    object.status.conditions.exists(c, c.type == 'ParentContextReady') ?
-                      object.status.conditions.filter(c, c.type == 'ParentContextReady')[0].reason : ''
+                  value: "item.reason"
                 - name: status
-                  value: |
-                    object.status.conditions.exists(c, c.type == 'ParentContextReady') ?
-                      object.status.conditions.filter(c, c.type == 'ParentContextReady')[0].status : ''
+                  value: "item.status"
 
     - name: quota-grant-creation-policy-enabled
       resource:
@@ -425,25 +396,19 @@ spec:
           help: "Status conditions for quota resource claims"
           type: gauge
           metrics:
-            - value: |
-                object.status.conditions.exists(c, c.type == 'Granted') ?
-                  (object.status.conditions.filter(c, c.type == 'Granted')[0].status == 'True' ? 1.0 : 0.0) :
-                  0.0
+            - forEach: "object.status.conditions"
+              value: "item.status == 'True' ? 1.0 : 0.0"
               labels:
                 - name: name
                   value: "object.metadata.name"
                 - name: namespace
                   value: "object.metadata.namespace"
                 - name: condition
-                  value: "'Granted'"
+                  value: "item.type"
                 - name: reason
-                  value: |
-                    object.status.conditions.exists(c, c.type == 'Granted') ?
-                      object.status.conditions.filter(c, c.type == 'Granted')[0].reason : ''
+                  value: "item.reason"
                 - name: status
-                  value: |
-                    object.status.conditions.exists(c, c.type == 'Granted') ?
-                      object.status.conditions.filter(c, c.type == 'Granted')[0].status : ''
+                  value: "item.status"
 
     - name: quota-resource-claim-observed-generation
       resource:
@@ -514,25 +479,19 @@ spec:
           help: "Status conditions for quota resource grants"
           type: gauge
           metrics:
-            - value: |
-                object.status.conditions.exists(c, c.type == 'Active') ?
-                  (object.status.conditions.filter(c, c.type == 'Active')[0].status == 'True' ? 1.0 : 0.0) :
-                  0.0
+            - forEach: "object.status.conditions"
+              value: "item.status == 'True' ? 1.0 : 0.0"
               labels:
                 - name: name
                   value: "object.metadata.name"
                 - name: namespace
                   value: "object.metadata.namespace"
                 - name: condition
-                  value: "'Active'"
+                  value: "item.type"
                 - name: reason
-                  value: |
-                    object.status.conditions.exists(c, c.type == 'Active') ?
-                      object.status.conditions.filter(c, c.type == 'Active')[0].reason : ''
+                  value: "item.reason"
                 - name: status
-                  value: |
-                    object.status.conditions.exists(c, c.type == 'Active') ?
-                      object.status.conditions.filter(c, c.type == 'Active')[0].status : ''
+                  value: "item.status"
 
     - name: quota-resource-grant-observed-generation
       resource:
@@ -611,23 +570,17 @@ spec:
           help: "Status conditions for quota resource registrations"
           type: gauge
           metrics:
-            - value: |
-                object.status.conditions.exists(c, c.type == 'Active') ?
-                  (object.status.conditions.filter(c, c.type == 'Active')[0].status == 'True' ? 1.0 : 0.0) :
-                  0.0
+            - forEach: "object.status.conditions"
+              value: "item.status == 'True' ? 1.0 : 0.0"
               labels:
                 - name: name
                   value: "object.metadata.name"
                 - name: condition
-                  value: "'Active'"
+                  value: "item.type"
                 - name: reason
-                  value: |
-                    object.status.conditions.exists(c, c.type == 'Active') ?
-                      object.status.conditions.filter(c, c.type == 'Active')[0].reason : ''
+                  value: "item.reason"
                 - name: status
-                  value: |
-                    object.status.conditions.exists(c, c.type == 'Active') ?
-                      object.status.conditions.filter(c, c.type == 'Active')[0].status : ''
+                  value: "item.status"
 
     - name: quota-resource-registration-observed-generation
       resource: