Skip to content

Commit 8cb2c82

Browse files
authored
chore: add display names and descriptions to system roles (#519)
## Summary - Adds `kubernetes.io/display-name` and `kubernetes.io/description` annotations to 9 system roles that were showing raw internal names in the cloud portal UI - Affected roles: `core-admin`, `core-editor`, `core-reader`, `resourcemanager-admin`, `resourcemanager-editor`, `resourcemanager-reader`, `apiextensions-reader`, `quota.miloapis.com-viewer`, `quota.miloapis.com-organization-quota-manager` ## Test plan - [ ] Verify roles display friendly names in the cloud portal Add Role screen - [ ] Confirm annotations are applied correctly after deploy
2 parents 11387d8 + bda5436 commit 8cb2c82

9 files changed

Lines changed: 27 additions & 0 deletions

config/roles/apiextensions-reader.yaml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,9 @@ apiVersion: iam.miloapis.com/v1alpha1
22
kind: Role
33
metadata:
44
name: apiextensions-reader
5+
annotations:
6+
kubernetes.io/display-name: API Extensions Viewer
7+
kubernetes.io/description: View access to custom resource definitions
58
spec:
69
launchStage: Beta
710
includedPermissions:

config/roles/core-admin.yaml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,9 @@ apiVersion: iam.miloapis.com/v1alpha1
22
kind: Role
33
metadata:
44
name: core-admin
5+
annotations:
6+
kubernetes.io/display-name: Core Admin
7+
kubernetes.io/description: Full access to core platform resources including secrets, configmaps, and namespaces
58
spec:
69
launchStage: Beta
710
inheritedRoles:

config/roles/core-editor.yaml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,9 @@ apiVersion: iam.miloapis.com/v1alpha1
22
kind: Role
33
metadata:
44
name: core-editor
5+
annotations:
6+
kubernetes.io/display-name: Core Editor
7+
kubernetes.io/description: Edit access to core platform resources including secrets, configmaps, and namespaces
58
spec:
69
launchStage: Beta
710
inheritedRoles:

config/roles/core-reader.yaml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,9 @@ apiVersion: iam.miloapis.com/v1alpha1
22
kind: Role
33
metadata:
44
name: core-reader
5+
annotations:
6+
kubernetes.io/display-name: Core Reader
7+
kubernetes.io/description: View access to core platform resources including secrets, configmaps, and namespaces
58
spec:
69
launchStage: Beta
710
includedPermissions:

config/roles/resourcemanager-admin.yaml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,9 @@ apiVersion: iam.miloapis.com/v1alpha1
22
kind: Role
33
metadata:
44
name: resourcemanager-admin
5+
annotations:
6+
kubernetes.io/display-name: Resource Manager Admin
7+
kubernetes.io/description: Full access to organizations and projects
58
spec:
69
launchStage: Beta
710
inheritedRoles:

config/roles/resourcemanager-editor.yaml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,9 @@ apiVersion: iam.miloapis.com/v1alpha1
22
kind: Role
33
metadata:
44
name: resourcemanager-editor
5+
annotations:
6+
kubernetes.io/display-name: Resource Manager Editor
7+
kubernetes.io/description: Edit access to organizations and projects
58
spec:
69
launchStage: Beta
710
inheritedRoles:

config/roles/resourcemanager-reader.yaml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,9 @@ apiVersion: iam.miloapis.com/v1alpha1
22
kind: Role
33
metadata:
44
name: resourcemanager-reader
5+
annotations:
6+
kubernetes.io/display-name: Resource Manager Viewer
7+
kubernetes.io/description: View access to organizations and projects
58
spec:
69
launchStage: Beta
710
includedPermissions:

config/services/quota/iam/roles/organization-quota-manager.yaml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,9 @@ kind: Role
33
metadata:
44
name: quota.miloapis.com-organization-quota-manager
55
namespace: milo-system
6+
annotations:
7+
kubernetes.io/display-name: Organization Quota Manager
8+
kubernetes.io/description: View quota usage, grants, and claims across the organization
69
labels:
710
quota.miloapis.com/role-type: organization-manager
811
quota.miloapis.com/service: quota

config/services/quota/iam/roles/quota-viewer.yaml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,9 @@ kind: Role
33
metadata:
44
name: quota.miloapis.com-viewer
55
namespace: milo-system
6+
annotations:
7+
kubernetes.io/display-name: Quota Viewer
8+
kubernetes.io/description: View access to quota resources including resource registrations, grants, and claims
69
labels:
710
quota.miloapis.com/role-type: viewer
811
quota.miloapis.com/service: quota

0 commit comments

Comments
 (0)