Plugin Directory: Fix PHP warnings for undefined array keys in upload handler.

Two loops reused a variable name that overwrote the full plugin check
result. When the code later tried to read the process output and error
details, those keys didn't exist on the individual check record.

Also ensures the early return when the process fails to start includes
all expected keys, matching the structure returned on the normal path.

git-svn-id: https://meta.svn.wordpress.org/sites/trunk@14783 74240141-8908-4e6f-9713-ba540dce6ec7

Author: obenland

wordpress.org/public_html/wp-content/plugins/plugin-directory/jobs/class-plugin-updates-pcp.php

@@ -358,9 +358,16 @@ public static function run_plugin_check( $plugin_slug, $path, $tag = '', $mode =
 		if ( ! $plugin_check_process ) {
 			// If we can't run plugin-check, we'll just return a pass.
 			return [
-				'verdict' => true,
-				'results' => [],
-				'html'    => '',
+				'verdict'         => true,
+				'results'         => [],
+				'results_by_type' => [],
+				'files'           => [],
+				'totals'          => [ 'errors' => 0, 'warnings' => 0 ],
+				'return_code'     => 0,
+				'output'          => [],
+				'stderr'          => '',
+				'total_time'      => 0,
+				'hash'            => '',
 			];
 		}
 

wordpress.org/public_html/wp-content/plugins/plugin-directory/shortcodes/class-upload-handler.php

@@ -814,14 +814,14 @@ public function check_plugin() {
 					$maybe_false_positive = __( 'This may be a false-positive, and will be manually checked by a reviewer.', 'wporg-plugins' );
 				}
 
-				foreach ( $result_set as $result ) {
+				foreach ( $result_set as $check_result ) {
 					$html .= sprintf(
 						'<li>%s <a href="%s" title="%s">%s</a>: %s</li>',
-						esc_html( $result['file'] ),
-						esc_url( $result['docs'] ?? '' ),
+						esc_html( $check_result['file'] ),
+						esc_url( $check_result['docs'] ?? '' ),
 						esc_attr( $maybe_false_positive ),
-						esc_html( "{$result_label}: {$result['code']}" ),
-						$result['message'] // Already escaped.
+						esc_html( "{$result_label}: {$check_result['code']}" ),
+						$check_result['message'] // Already escaped.
 					);
 				}
 			}
@@ -851,9 +851,9 @@ public function check_plugin() {
 
 			// Include a simplified / merged version of the results for review.
 			$group_by_code = [ 'ERROR' => [], 'WARNING' => [] ];
-			foreach ( $results as $result ) {
-				$group_by_code[ $result['type'] ][ $result['code'] ] ??= [];
-				$group_by_code[ $result['type'] ][ $result['code'] ][] = $result;
+			foreach ( $results as $check_result ) {
+				$group_by_code[ $check_result['type'] ][ $check_result['code'] ] ??= [];
+				$group_by_code[ $check_result['type'] ][ $check_result['code'] ][] = $check_result;
 			}
 			foreach ( $group_by_code as $type => $codes ) {
 				foreach ( $codes as $code_results ) {