v3.0.7 (#36)

Co-authored-by: ddc <ddc@users.noreply.github.com>

Author: ddc

README.md

@@ -68,9 +68,18 @@
 ## Default Session Settings
 
 - `autoflush = False`
-- `expire_on_commit = False` 
+- `expire_on_commit = False`
 - `echo = False`
 
+**Autocommit Defaults by Database:**
+
+| Database   | Default | Convention                       |
+|------------|---------|----------------------------------|
+| PostgreSQL | `False` | Uses transactions by default     |
+| MSSQL      | `False` | Uses transactions by default     |
+| MySQL      | `True`  | Autocommit ON is MySQL's default |
+| Oracle     | `False` | Requires explicit COMMIT         |
+
 **Note:** All constructor parameters are optional and fall back to [.env](./ddcDatabases/.env.example) file variables.
 
 

ddcDatabases/.env.example

@@ -134,7 +134,7 @@ ORACLE_SERVICENAME=xe
 ORACLE_ECHO=false
 ORACLE_AUTOFLUSH=false
 ORACLE_EXPIRE_ON_COMMIT=false
-ORACLE_AUTOCOMMIT=true
+ORACLE_AUTOCOMMIT=false
 # Pool settings
 ORACLE_CONNECTION_TIMEOUT=30
 ORACLE_POOL_RECYCLE=3600

ddcDatabases/core/settings.py

@@ -240,7 +240,7 @@ class OracleSettings(_BaseDBSettings):
     echo: bool = Field(default=False, description=Msg.ECHO_DESCRIPTION)
     autoflush: bool = Field(default=False, description=Msg.AUTOFLUSH_DESCRIPTION)
     expire_on_commit: bool = Field(default=False, description=Msg.EXPIRE_ON_COMMIT_DESCRIPTION)
-    autocommit: bool = Field(default=True, description=Msg.AUTOCOMMIT_DESCRIPTION)
+    autocommit: bool = Field(default=False, description=Msg.AUTOCOMMIT_DESCRIPTION)
     connection_timeout: int = Field(default=30, description=Msg.CONNECTION_TIMEOUT_DESCRIPTION)
     pool_recycle: int = Field(default=3600, description=Msg.POOL_RECYCLE_DESCRIPTION)
     pool_size: int = Field(default=10, description=Msg.POOL_SIZE_DESCRIPTION)

tests/unit/test_oracle.py

@@ -21,17 +21,24 @@ def _create_mock_settings(self, **overrides):
             "sync_driver": "oracle+oracledb",
             "autoflush": False,
             "expire_on_commit": False,
-            "autocommit": True,
+            "autocommit": False,
             "connection_timeout": 30,
             "pool_recycle": 3600,
             "pool_size": 10,
             "max_overflow": 20,
             "ssl_enabled": False,
             "ssl_wallet_path": None,
-            "enable_retry": True,
-            "max_retries": 3,
-            "initial_retry_delay": 1.0,
-            "max_retry_delay": 30.0,
+            # Connection retry settings
+            "conn_enable_retry": True,
+            "conn_max_retries": 3,
+            "conn_initial_retry_delay": 1.0,
+            "conn_max_retry_delay": 30.0,
+            # Operation retry settings
+            "op_enable_retry": True,
+            "op_max_retries": 3,
+            "op_initial_retry_delay": 0.5,
+            "op_max_retry_delay": 10.0,
+            "op_jitter": 0.1,
         }
         defaults.update(overrides)
         for key, value in defaults.items():
@@ -220,7 +227,7 @@ def test_all_parameters_defaults(self, mock_get_settings):
 
         assert oracle._session_config.autoflush == False
         assert oracle._session_config.expire_on_commit == False
-        assert oracle._session_config.autocommit == True
+        assert oracle._session_config.autocommit == False
         assert oracle._pool_config.connection_timeout == 30
 
     @patch('ddcDatabases.oracle.get_oracle_settings')