TBF

Author: ddebin

.github/workflows/main.yml

@@ -9,7 +9,7 @@ jobs:
     runs-on: ubuntu-24.04
     strategy:
       matrix:
-        php: ['7.1', '7.2', '7.3', '7.4', '8.0', '8.1', '8.2', '8.3', '8.4', '8.5']
+        php: ['7.2', '7.3', '7.4', '8.0', '8.1', '8.2', '8.3', '8.4', '8.5']
     name: PHP ${{ matrix.php }}
     steps:
       -   uses: actions/checkout@v6
@@ -32,7 +32,7 @@ jobs:
             fetch-depth: 5
       -   uses: shivammathur/setup-php@v2
           with:
-            php-version: '7.1'
+            php-version: '7.2'
             tools: composer:2
             coverage: none
       -   run: composer update --no-progress --prefer-lowest

composer.json

@@ -22,16 +22,16 @@
         }
     ],
     "require": {
-        "php": "^7.1 || ^8.0",
+        "php": "^7.2 || ^8.0",
         "ext-json": "*",
         "ext-pdo": "*"
     },
     "require-dev": {
         "friendsofphp/php-cs-fixer": "^3.0",
-        "phpstan/phpstan": "^1.4",
+        "phpstan/phpstan": "^1.12",
         "phpstan/phpstan-phpunit": "^1.0",
         "phpstan/phpstan-strict-rules": "^1.0",
-        "phpunit/phpunit": "^7.0 || ^8.0 || ^9.0"
+        "phpunit/phpunit": "^8.0 || ^9.0"
     },
     "config": {
         "sort-packages": true

lib/MC/Google/Visualization.php

@@ -1007,7 +1007,6 @@ protected function generateSQL(array &$meta): string
             $stmt = $this->db->query($pivotSql);
             assert(false !== $stmt);
             $rows = $stmt->fetchAll(PDO::FETCH_ASSOC);
-            assert(false !== $rows);
             foreach ($rows as $row) {
                 // Create a version of all function-ed fields for each unique combination of pivot values
                 foreach ($funcFields as $field) {

phpstan.neon

@@ -3,6 +3,8 @@ includes:
     - vendor/phpstan/phpstan-phpunit/rules.neon
     - vendor/phpstan/phpstan-strict-rules/rules.neon
 parameters:
-    checkMissingIterableValueType: false
     reportUnmatchedIgnoredErrors: true
-    treatPhpDocTypesAsCertain: false
+    treatPhpDocTypesAsCertain: false
+    ignoreErrors:
+        -
+            identifier: missingType.iterableValue