update ci

Author: alinelena

.github/build.yml

@@ -27,13 +27,13 @@ jobs:
     - name: Install dependencies
       run: |
         python -m pip install --upgrade pip
-        python -m pip install flake8 pytest
+        python -m pip install flake8 tox
     - name: Lint with flake8
       run: |
         # stop the build if there are Python syntax errors or undefined names
         flake8 . --count --select=E9,F63,F7,F82 --show-source --statistics
         # exit-zero treats all errors as warnings. The GitHub editor is 127 chars wide
         flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --statistics
-    - name: Test with pytest
+    - name: Test with tox
       run: |
-        pytest
+        tox

.github/workflows/python-package.yml

@@ -5,7 +5,6 @@
 >>> from data_tutorials.data import get_data
 >>> get_data(url="my_file_url", filename="mycif", folder="data")
 
-
 """
 
 from importlib.metadata import version

data_tutorials/__init__.py

@@ -6,6 +6,8 @@
 
 from urllib.request import urlretrieve
 from pathlib import Path
+# this is only for python 3.9 once done use str| list[str]
+from typing import Union
 
 default_url = "https://raw.githubusercontent.com/ddmms/data-tutorials/main/data/"
 def download_file(url: str, filename:str, dest: Path) -> None:
@@ -17,7 +19,7 @@ def download_file(url: str, filename:str, dest: Path) -> None:
     else:
         print(f"{save_file} could not be downloaded, check url.")
 
-def get_data(url: str=default_url, filename: str| list[str] = "", folder: str="data") -> None:
+def get_data(url: str=default_url, filename: Union[str, list[str]] = "", folder: str="data") -> None:
     p = Path(folder)
     p.mkdir(parents=True, exist_ok=True)
     if isinstance(filename,str):

data_tutorials/data.py

@@ -11,7 +11,11 @@
 def test_download_file():
    get_data(filename="LiFePO4_supercell.cif",folder="data-test")
    with open(Path("data-test")/"LiFePO4_supercell.cif", "rb") as fd:
-      h  = hashlib.file_digest(fd, "sha256")
+      try:
+        h  = hashlib.file_digest(fd, "sha256")
+      except AttributeError:
+        h  = hashlib.sha256()
+        h.update(fd.read())
    assert h.hexdigest() == "ea9a538dde5bb84b92e9478dbcc078bb560b28a4f5e4b0469d416bff36be272e"
 
 def test_download_files():
@@ -21,5 +25,9 @@ def test_download_files():
    get_data(filename=files,folder="data-test")
    for f in files:
       with open(Path("data-test")/f, "rb") as fd:
-         h  = hashlib.file_digest(fd, "sha256")
+         try:
+           h  = hashlib.file_digest(fd, "sha256")
+         except AttributeError:
+           h  = hashlib.sha256()
+           h.update(fd.read())
       assert h.hexdigest() == sha256[f]

tests/test_file.py

@@ -0,0 +1,6 @@
+[tox]
+envlist = py3
+
+[testenv]
+deps = pytest 
+commands = pytest