Skip to content

Commit a69a575

Browse files
committed
* Fixed bug where children shown "to the right" of argument nodes (eg. freeform children) would not get included in the "expand to show" count of children. (well, it would only count relevance children for this calc before)
1 parent 3724288 commit a69a575

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

  • Packages/client/Source/UI/@Shared/Maps/Node

Packages/client/Source/UI/@Shared/Maps/Node/NodeUI.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -203,7 +203,8 @@ export class NodeUI extends BaseComponentPlus(
203203
}
204204

205205
//const childrenShownByNodeExpandButton = nodeChildrenToShow.length + (hereArgChildrenToShow?.length ?? 0);
206-
const childrenShownByNodeExpandButton = (node.type == NodeType.argument ? ncToShow_relevance : nodeChildrenToShow).filter(a=>a.type != NodeType.comment);
206+
// we exclude premise and comment children from this expand-to-show count, because these are shown in other places (premises as vertically-below the node, and comments in the node's "Comments" panel)
207+
const childrenShownByNodeExpandButton = (node.type == NodeType.argument ? nodeChildrenToShow.Exclude(...ncToShow_generic) : nodeChildrenToShow).filter(a=>a.type != NodeType.comment);
207208

208209
const playback = GetPlaybackInfo();
209210
const showFocusNodeStatusMarker = playback?.timeline != null && store.main.timelines.showFocusNodes;

0 commit comments

Comments
 (0)