@@ -34,22 +34,24 @@ public class Clan {
3434 private List <BungieUser > admins ;
3535 private List <BungieUser > members = new ArrayList <>();
3636 private ClanManagement clanManagement ;
37+ private JsonObject jso ;
38+ private JsonArray ja ;
3739
3840 public Clan (long clanId ) {
3941 this .clanId = clanId ;
40- cjo = hu .urlRequestGET ("https://www.bungie.net/platform/GroupV2/" + clanId +"/?components=200" ).get ("Response" ).getAsJsonObject ().get ("detail" ).getAsJsonObject ();
42+ cjo = hu .urlRequestGET ("https://www.bungie.net/platform/GroupV2/" + clanId + "/?components=200" ).get ("Response" ).getAsJsonObject ().get ("detail" ).getAsJsonObject ();
4143 assignValues ();
4244 }
4345
4446 public Clan (String clanName ) {
4547 this .clanName = clanName ;
46- jo = hu .urlRequestGET ("https://www.bungie.net/Platform/GroupV2/Name/" + clanName .replace (" " , "%20" ) +"/1/?components=200" ).get ("Response" ).getAsJsonObject ();
48+ jo = hu .urlRequestGET ("https://www.bungie.net/Platform/GroupV2/Name/" + clanName .replace (" " , "%20" ) + "/1/?components=200" ).get ("Response" ).getAsJsonObject ();
4749 cjo = jo .get ("detail" ).getAsJsonObject ();
4850 assignValues ();
4951 }
5052
5153 private void assignValues () {
52- if (clanName == null ) { // If the clan object was created via ID then the clanName would be null by default
54+ if (clanName == null ) { // If the clan object was created via ID then the clanName would be null by default
5355 clanName = cjo .get ("name" ).getAsString ();
5456 } else { // Opposite of previous reason
5557 clanId = cjo .get ("groupId" ).getAsLong ();
@@ -92,33 +94,33 @@ public String getClanName() {
9294 * Followed by the admins in the order they were promoted
9395 */
9496 public List <BungieUser > getAdmins () {
95- if (admins != null ) return admins ;
97+ if (admins != null ) { return admins ; }
9698
9799 List <BungieUser > temp = new ArrayList <>();
98100 JsonArray ja = hu .urlRequestGET ("https://www.bungie.net/Platform/GroupV2/" + clanId + "/AdminsAndFounder/?componenets=200" ).get ("Response" ).getAsJsonObject ().get ("results" ).getAsJsonArray ();
99101
100- for (JsonElement je : ja ) {
102+ for (JsonElement je : ja ) {
101103 temp .add (new BungieUser (je .getAsJsonObject ().get ("destinyUserInfo" ).getAsJsonObject ().get ("membershipId" ).getAsString ()));
102104 }
103105
104106 return temp ;
105107 }
106108
107109 public List <BungieUser > getMembers () {
108- if (!members .isEmpty ()) return members ;
110+ if (!members .isEmpty ()) { return members ; }
109111
110- JsonObject jo = hu .urlRequestGET ("https://www.bungie.net/Platform/GroupV2/" + clanId + "/Members/" ).get ("Response" ).getAsJsonObject ();
112+ jso = hu .urlRequestGET ("https://www.bungie.net/Platform/GroupV2/" + clanId + "/Members/" ).get ("Response" ).getAsJsonObject ();
111113
112- for (JsonElement je : jo .get ("results" ).getAsJsonArray ()) {
114+ for (JsonElement je : jso .get ("results" ).getAsJsonArray ()) {
113115 members .add (new BungieUser (je .getAsJsonObject ().get ("destinyUserInfo" ).getAsJsonObject ().get ("membershipId" ).getAsString ()));
114116 }
115117
116118 return members ;
117119 }
118120
119121 public ClanManagement getClanManagement () {
120- if (clanManagement != null ) return clanManagement ;
122+ if (clanManagement != null ) { return clanManagement ; }
121123 clanManagement = new ClanManagement (this );
122- return clanManagement ;
124+ return clanManagement ;
123125 }
124126}
0 commit comments