Merge pull request #102 from deep-compute/remove_pickle_protocol

Removing support of pickle protocol

Author: Venu

.travis.yml

@@ -9,8 +9,8 @@ deploy:
   - LICENSE
   - kwikapi/api.py
   - kwikapi/__init__.py
-  name: kwikapi-0.5.13
-  tag_name: 0.5.13
+  name: kwikapi-0.5.14
+  tag_name: 0.5.14
   true:
     repo: deep-compute/kwikapi
 - provider: pypi

README.md

@@ -425,7 +425,7 @@ $ wget "http://localhost:8888/api/v1/streaming_request_test" --post-file /tmp/nu
 ```
 
 ### Protocol handling
-KwikAPI supports JSON, Messagepack, Pickle and Numpy protocols
+KwikAPI supports JSON, Messagepack and Numpy protocols
 
 #### KwikAPI also supports custom protocols instead of using existing protocols
 ```python 
@@ -513,7 +513,6 @@ ex:
 ```bash
 $ wget "http://localhost:8888/api/v1/add" --header="X-KwikAPI-Protocol: messagepack" --post-file /tmp/data.msgpack
 $ wget "http://localhost:8888/api/v1/subtract" --header="X-KwikAPI-Protocol: json" --post-data '{"a": 10, "b": 20}'
-$ wget "http://localhost:8888/api/v1/add" --header="X-KwikAPI-Protocol: pickle" --post-file /tmp/data.pickle
 $ wget "http://localhost:8888/api/v1/add" --header="X-KwikAPI-Protocol: numpy" --post-file /tmp/data.numpy
 $ wget "http://localhost:8888/api/v1/add?a=10&b=20" --header="X-KwikAPI-Protocol: raw"
 ```
@@ -612,7 +611,7 @@ print(c.namespace.add(a=10, b=10))
 
 # Parameters can be changed that are passed to the Client object
 
-print(c(version='v2', protocol='pickle').namespace.add(a=10, b=10))
+print(c(version='v2', protocol='messagepack').namespace.add(a=10, b=10))
 ```
 
 Streaming response is handled by passing the parameter `stream` as True.

kwikapi/__init__.py

@@ -2,7 +2,7 @@
 from .api import MockRequest, BaseRequest, BaseResponse, Request
 
 from .protocols import BaseProtocol, JsonProtocol, MessagePackProtocol
-from .protocols import PickleProtocol, NumpyProtocol
+from .protocols import NumpyProtocol
 from .protocols import PROTOCOLS
 
 from .client import Client, DNSCache

kwikapi/client.py

@@ -43,7 +43,7 @@ def map_url(self, url):
 
 
 class Client:
-    DEFAULT_PROTOCOL = "pickle"
+    DEFAULT_PROTOCOL = "messagepack"
 
     def __init__(
         self,

kwikapi/protocols.py

@@ -1,7 +1,6 @@
 import ast
 import abc
 import json
-import pickle
 import msgpack
 import numpy as np
 
@@ -42,7 +41,6 @@ def should_wrap():
         While returning the response the,
         kwikapi will wrap the response as -
         {success: value, result: value}
-
         This method, can used in above situation,
         if no wrapping is required,
         override this method in the protocol class.
@@ -107,32 +105,6 @@ def get_mime_type():
         return "application/x-msgpack"
 
 
-class PickleProtocol(BaseProtocol):
-    @staticmethod
-    def get_name():
-        return "pickle"
-
-    @staticmethod
-    def serialize(data):
-        return pickle.dumps(data)
-
-    @staticmethod
-    def deserialize(data):
-        return pickle.loads(data)
-
-    @classmethod
-    def deserialize_stream(cls, data):
-        raise StreamingNotSupported(cls.get_name())
-
-    @classmethod
-    def get_record_separator(cls):
-        raise StreamingNotSupported(cls.get_name())
-
-    @staticmethod
-    def get_mime_type():
-        return "application/pickle"
-
-
 class RawProtocol(BaseProtocol):
     @staticmethod
     def get_name():
@@ -227,13 +199,7 @@ def get_mime_type():
 
 PROTOCOLS = dict(
     (p.get_name(), p)
-    for p in [
-        JsonProtocol,
-        MessagePackProtocol,
-        PickleProtocol,
-        NumpyProtocol,
-        RawProtocol,
-    ]
+    for p in [RawProtocol, JsonProtocol, NumpyProtocol, MessagePackProtocol]
 )
 
 DEFAULT_PROTOCOL = JsonProtocol.get_name()

setup.py

@@ -1,6 +1,6 @@
 from setuptools import setup, find_packages
 
-version = "0.5.13"
+version = "0.5.14"
 setup(
     name="kwikapi",
     version=version,