Commit 274aa41
committed
fix(listen): fix three root causes of missing transcript output
1. Boolean options as API strings (listen command)
Deepgram REST API rejects Python booleans — 'True' is not a valid
value for punctuate/smart_format. The streaming path already used
"true"/"false" strings correctly; the prerecorded path did not.
2. Flag options defaulting to None instead of False (plugin_manager)
click.option() was created with default=arg.get("default") which
returns None when the arg spec has no "default" key. Click then
passes None in kwargs instead of False, breaking any command that
passes flag values to Pydantic bool fields.
3. type=str applied to flag options (plugin_manager)
Passing type=str to is_flag=True options causes Click to coerce
the False default to the string "False" (truthy), making every
unset flag appear active. Fixed by skipping type for flags entirely.
The plugin_manager bugs (2+3) affected all 75 flag options across
every command in the CLI. The fix is backward-compatible: None → False
is still falsy, but now also passes Pydantic bool validation.1 parent 982e644 commit 274aa41
2 files changed
Lines changed: 21 additions & 11 deletions
File tree
- packages
- deepctl-cmd-listen/src/deepctl_cmd_listen
- deepctl-core/src/deepctl_core
Lines changed: 5 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
519 | 519 | | |
520 | 520 | | |
521 | 521 | | |
| 522 | + | |
| 523 | + | |
| 524 | + | |
522 | 525 | | |
523 | 526 | | |
524 | 527 | | |
525 | | - | |
526 | | - | |
| 528 | + | |
| 529 | + | |
527 | 530 | | |
528 | 531 | | |
529 | 532 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
422 | 422 | | |
423 | 423 | | |
424 | 424 | | |
425 | | - | |
426 | | - | |
427 | | - | |
428 | | - | |
429 | | - | |
430 | | - | |
431 | | - | |
432 | | - | |
433 | | - | |
| 425 | + | |
| 426 | + | |
| 427 | + | |
| 428 | + | |
| 429 | + | |
| 430 | + | |
| 431 | + | |
| 432 | + | |
| 433 | + | |
| 434 | + | |
| 435 | + | |
| 436 | + | |
| 437 | + | |
| 438 | + | |
| 439 | + | |
| 440 | + | |
434 | 441 | | |
435 | 442 | | |
436 | 443 | | |
| |||
0 commit comments