From 7691fa34e61f71119f7bd7e410a96dfb1c4cbd59 Mon Sep 17 00:00:00 2001 From: owjs3901 <12480623+owjs3901@users.noreply.github.com> Date: Thu, 22 Oct 2026 10:55:47 +0900 Subject: [PATCH] fix(components): give each Select trigger its own id Refs #692 Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus --- .../changepack_log_select_trigger_id.json | 7 ++ .../__snapshots__/index.browser.test.tsx.snap | 12 ++-- .../__tests__/trigger-id.browser.test.tsx | 72 +++++++++++++++++++ .../src/components/Select/index.tsx | 4 +- 4 files changed, 88 insertions(+), 7 deletions(-) create mode 100644 .changepacks/changepack_log_select_trigger_id.json create mode 100644 packages/components/src/components/Select/__tests__/trigger-id.browser.test.tsx diff --git a/.changepacks/changepack_log_select_trigger_id.json b/.changepacks/changepack_log_select_trigger_id.json new file mode 100644 index 000000000..2c23b8240 --- /dev/null +++ b/.changepacks/changepack_log_select_trigger_id.json @@ -0,0 +1,7 @@ +{ + "changes": { + "packages/components/package.json": "Patch" + }, + "note": "Each Select trigger now gets its own id from the Select id or a generated id, so several Selects on a page no longer share the id -trigger and each listbox is labelled by its own trigger; no new build errors.", + "date": "2026-10-22T00:00:00.000Z" +} diff --git a/packages/components/src/components/Select/__tests__/__snapshots__/index.browser.test.tsx.snap b/packages/components/src/components/Select/__tests__/__snapshots__/index.browser.test.tsx.snap index 9be955d4a..86a720dea 100644 --- a/packages/components/src/components/Select/__tests__/__snapshots__/index.browser.test.tsx.snap +++ b/packages/components/src/components/Select/__tests__/__snapshots__/index.browser.test.tsx.snap @@ -3,7 +3,7 @@ exports[`Select should render 1`] = ` "
- -
+
Option 1
@@ -54,7 +54,7 @@ exports[`Select should render with overflow screen 1`] = ` Option 4
-