Skip to content

Commit 776589a

Browse files
authored
[VPlan] Handle FindLast in VPIRFlags::printFlags (llvm#185857)
Noticed this when -vplan-print-after-all crashed on a find-last reduction. We don't yet return an opcode for it because there's no in-loop reduction.
1 parent aa90add commit 776589a

2 files changed

Lines changed: 94 additions & 0 deletions

File tree

llvm/lib/Transforms/Vectorize/VPlanRecipes.cpp

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2248,6 +2248,9 @@ void VPIRFlags::printFlags(raw_ostream &O) const {
22482248
case RecurKind::AnyOf:
22492249
O << "any-of";
22502250
break;
2251+
case RecurKind::FindLast:
2252+
O << "find-last";
2253+
break;
22512254
case RecurKind::SMax:
22522255
O << "smax";
22532256
break;
Lines changed: 91 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,91 @@
1+
; NOTE: Assertions have been autogenerated by utils/update_analyze_test_checks.py UTC_ARGS: --version 6
2+
; RUN: opt -disable-output %s -p loop-vectorize -force-vector-width=4 -vplan-print-after=optimizeFindIVReductions 2>&1 | FileCheck %s
3+
4+
define i32 @find_last_with_select(ptr noalias %a, ptr noalias %b) {
5+
; CHECK-LABEL: VPlan for loop in 'find_last_with_select'
6+
; CHECK: VPlan ' for UF>=1' {
7+
; CHECK-NEXT: Live-in vp<[[VP0:%[0-9]+]]> = VF
8+
; CHECK-NEXT: Live-in vp<[[VP1:%[0-9]+]]> = VF * UF
9+
; CHECK-NEXT: Live-in vp<[[VP2:%[0-9]+]]> = vector-trip-count
10+
; CHECK-NEXT: Live-in ir<500> = original trip-count
11+
; CHECK-EMPTY:
12+
; CHECK-NEXT: ir-bb<entry>:
13+
; CHECK-NEXT: Successor(s): scalar.ph, vector.ph
14+
; CHECK-EMPTY:
15+
; CHECK-NEXT: vector.ph:
16+
; CHECK-NEXT: Successor(s): vector loop
17+
; CHECK-EMPTY:
18+
; CHECK-NEXT: <x1> vector loop: {
19+
; CHECK-NEXT: vector.body:
20+
; CHECK-NEXT: EMIT vp<[[VP3:%[0-9]+]]> = CANONICAL-INDUCTION ir<0>, vp<%index.next>
21+
; CHECK-NEXT: ir<%iv> = WIDEN-INDUCTION nuw nsw ir<0>, ir<1>, vp<[[VP0]]>
22+
; CHECK-NEXT: WIDEN-REDUCTION-PHI ir<%rdx> = phi ir<1>, ir<%sel>
23+
; CHECK-NEXT: CLONE ir<%gep.a> = getelementptr inbounds ir<%a>, ir<%iv>
24+
; CHECK-NEXT: vp<[[VP4:%[0-9]+]]> = vector-pointer inbounds ir<%gep.a>
25+
; CHECK-NEXT: WIDEN ir<%load.a> = load vp<[[VP4]]>
26+
; CHECK-NEXT: CLONE ir<%gep.b> = getelementptr inbounds ir<%b>, ir<%iv>
27+
; CHECK-NEXT: vp<[[VP5:%[0-9]+]]> = vector-pointer inbounds ir<%gep.b>
28+
; CHECK-NEXT: WIDEN ir<%load.b> = load vp<[[VP5]]>
29+
; CHECK-NEXT: WIDEN ir<%cmp> = icmp slt ir<%load.a>, ir<%load.b>
30+
; CHECK-NEXT: WIDEN ir<%sel> = select ir<%cmp>, ir<%rdx>, ir<%load.a>
31+
; CHECK-NEXT: CLONE ir<%iv.next> = add nuw nsw ir<%iv>, ir<1>
32+
; CHECK-NEXT: CLONE ir<%exitcond> = icmp eq ir<%iv.next>, ir<500>
33+
; CHECK-NEXT: EMIT vp<%index.next> = add nuw vp<[[VP3]]>, vp<[[VP1]]>
34+
; CHECK-NEXT: EMIT branch-on-count vp<%index.next>, vp<[[VP2]]>
35+
; CHECK-NEXT: No successors
36+
; CHECK-NEXT: }
37+
; CHECK-NEXT: Successor(s): middle.block
38+
; CHECK-EMPTY:
39+
; CHECK-NEXT: middle.block:
40+
; CHECK-NEXT: EMIT vp<[[VP7:%[0-9]+]]> = compute-reduction-result (find-last) ir<%sel>
41+
; CHECK-NEXT: EMIT vp<[[VP8:%[0-9]+]]> = exiting-iv-value ir<%iv>
42+
; CHECK-NEXT: EMIT vp<[[VP9:%[0-9]+]]> = extract-last-part vp<[[VP7]]>
43+
; CHECK-NEXT: EMIT vp<[[VP10:%[0-9]+]]> = extract-last-lane vp<[[VP9]]>
44+
; CHECK-NEXT: EMIT vp<[[VP11:%[0-9]+]]> = extract-last-part vp<[[VP7]]>
45+
; CHECK-NEXT: EMIT vp<[[VP12:%[0-9]+]]> = extract-last-lane vp<[[VP11]]>
46+
; CHECK-NEXT: EMIT vp<%cmp.n> = icmp eq ir<500>, vp<[[VP2]]>
47+
; CHECK-NEXT: EMIT branch-on-cond vp<%cmp.n>
48+
; CHECK-NEXT: Successor(s): ir-bb<exit>, scalar.ph
49+
; CHECK-EMPTY:
50+
; CHECK-NEXT: ir-bb<exit>:
51+
; CHECK-NEXT: IR %sel.lcssa = phi i32 [ %sel, %loop ] (extra operand: vp<[[VP7]]> from middle.block)
52+
; CHECK-NEXT: No successors
53+
; CHECK-EMPTY:
54+
; CHECK-NEXT: scalar.ph:
55+
; CHECK-NEXT: EMIT-SCALAR vp<%bc.resume.val> = phi [ vp<[[VP8]]>, middle.block ], [ ir<0>, ir-bb<entry> ]
56+
; CHECK-NEXT: EMIT-SCALAR vp<%bc.merge.rdx> = phi [ vp<[[VP7]]>, middle.block ], [ ir<1>, ir-bb<entry> ]
57+
; CHECK-NEXT: Successor(s): ir-bb<loop>
58+
; CHECK-EMPTY:
59+
; CHECK-NEXT: ir-bb<loop>:
60+
; CHECK-NEXT: IR %iv = phi i64 [ 0, %entry ], [ %iv.next, %loop ] (extra operand: vp<%bc.resume.val> from scalar.ph)
61+
; CHECK-NEXT: IR %rdx = phi i32 [ 1, %entry ], [ %sel, %loop ] (extra operand: vp<%bc.merge.rdx> from scalar.ph)
62+
; CHECK-NEXT: IR %gep.a = getelementptr inbounds i32, ptr %a, i64 %iv
63+
; CHECK-NEXT: IR %load.a = load i32, ptr %gep.a, align 4
64+
; CHECK-NEXT: IR %gep.b = getelementptr inbounds i32, ptr %b, i64 %iv
65+
; CHECK-NEXT: IR %load.b = load i32, ptr %gep.b, align 4
66+
; CHECK-NEXT: IR %cmp = icmp slt i32 %load.a, %load.b
67+
; CHECK-NEXT: IR %sel = select i1 %cmp, i32 %rdx, i32 %load.a
68+
; CHECK-NEXT: IR %iv.next = add nuw nsw i64 %iv, 1
69+
; CHECK-NEXT: IR %exitcond = icmp eq i64 %iv.next, 500
70+
; CHECK-NEXT: No successors
71+
; CHECK-NEXT: }
72+
;
73+
entry:
74+
br label %loop
75+
76+
loop:
77+
%iv = phi i64 [ 0, %entry ], [ %iv.next, %loop ]
78+
%rdx = phi i32 [ 1, %entry ], [ %sel, %loop ]
79+
%gep.a = getelementptr inbounds i32, ptr %a, i64 %iv
80+
%load.a = load i32, ptr %gep.a, align 4
81+
%gep.b = getelementptr inbounds i32, ptr %b, i64 %iv
82+
%load.b = load i32, ptr %gep.b, align 4
83+
%cmp = icmp slt i32 %load.a, %load.b
84+
%sel = select i1 %cmp, i32 %rdx, i32 %load.a
85+
%iv.next = add nuw nsw i64 %iv, 1
86+
%exitcond = icmp eq i64 %iv.next, 500
87+
br i1 %exitcond, label %exit, label %loop
88+
89+
exit:
90+
ret i32 %sel
91+
}

0 commit comments

Comments
 (0)