Skip to content

Commit 7732f76

Browse files
committed
move back pnpm-workspace.yaml
1 parent 0fb1699 commit 7732f76

16 files changed

Lines changed: 28 additions & 47 deletions

File tree

.config/cspell/cspell.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,5 +3,5 @@
33
"enableGlobDot": true,
44
"useGitignore": true,
55
"ignorePaths": ["**/node_modules/**", "LICENSE"],
6-
"words": ["devcontainer", "devcontainers", "execa", "packagejson", "pacote", "rsort", "syncpack"]
6+
"words": ["devcontainer", "devcontainers", "execa", "npmjs", "packagejson", "pacote", "rsort", "syncpack"]
77
}

.config/workspaces/package.json

Lines changed: 0 additions & 4 deletions
This file was deleted.
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
packages:
2+
- "create-devcontainer/**"
3+
- "!**/dist/"

.devcontainer/Dockerfile

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,3 @@
11
FROM mcr.microsoft.com/devcontainers/javascript-node:20
2-
ARG WORKSPACES
3-
ARG COMPOSE_PROJECT_NAME
4-
5-
RUN NODE_MODULES_PATH=${WORKSPACES}/${COMPOSE_PROJECT_NAME}/node_modules && \
6-
mkdir --parents "${NODE_MODULES_PATH}" && \
7-
chown $(id --user --name 1000): "${NODE_MODULES_PATH}"
82

93
RUN npm install --global pnpm@latest-9

.devcontainer/docker-compose.yml

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,6 @@ services:
55
build:
66
context: .
77
dockerfile: Dockerfile
8-
args:
9-
- WORKSPACES=${WORKSPACES}
10-
- COMPOSE_PROJECT_NAME=${COMPOSE_PROJECT_NAME}
118
init: true
129
volumes:
1310
- WORKSPACES:${WORKSPACES}
@@ -16,12 +13,9 @@ services:
1613
- XDG_CACHE_HOME:${XDG_CACHE_HOME}
1714
- XDG_DATA_HOME:${XDG_DATA_HOME}
1815
- XDG_STATE_HOME:${XDG_STATE_HOME}
19-
- node_modules:${WORKSPACES}/${COMPOSE_PROJECT_NAME}/node_modules
20-
- node_modules:${WORKSPACES}/node_modules
2116
volumes:
2217
WORKSPACES:
2318
XDG_CONFIG_HOME:
2419
XDG_CACHE_HOME:
2520
XDG_DATA_HOME:
2621
XDG_STATE_HOME:
27-
node_modules:

.devcontainer/dot-config.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
"workspaces": {
1616
"../git/attributes": ".gitattributes",
1717
"../git/ignore": ".gitignore",
18-
"package.json": "package.json"
18+
"../../package.json": "package.json",
19+
"pnpm-workspace.yaml": "pnpm-workspace.yaml"
1920
}
2021
}

create-devcontainer/configs/base/dotConfig.ts

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,24 +7,26 @@ export interface BaseDotConfigs {
77
".config/git/ignore": string;
88
".config/pnpm/rc": string;
99
".config/prettier/.prettierrc.json": string;
10-
".config/workspaces/package.json": string;
10+
".config/workspaces/pnpm-workspace.yaml": string;
1111
}
1212

13-
export const createBaseDotConfigs = async (remoteUser: string): Promise<BaseDotConfigs> => {
13+
export const createBaseDotConfigs = async (projectName: string, remoteUser: string): Promise<BaseDotConfigs> => {
1414
const templates = await loadTemplates("base", [
1515
".config/cspell/cspell.json",
1616
".config/git/attributes",
1717
".config/git/ignore",
1818
".config/pnpm/rc",
1919
".config/prettier/.prettierrc.json",
20-
".config/workspaces/package.json",
20+
".config/workspaces/pnpm-workspace.yaml",
2121
] satisfies (keyof BaseDotConfigs)[]);
2222
return {
2323
".config/cspell/cspell.json": templates[".config/cspell/cspell.json"],
2424
".config/git/attributes": templates[".config/git/attributes"],
2525
".config/git/ignore": templates[".config/git/ignore"],
2626
".config/pnpm/rc": fillTemplate(templates[".config/pnpm/rc"], { remoteUser }),
2727
".config/prettier/.prettierrc.json": templates[".config/prettier/.prettierrc.json"],
28-
".config/workspaces/package.json": templates[".config/workspaces/package.json"],
28+
".config/workspaces/pnpm-workspace.yaml": fillTemplate(templates[".config/workspaces/pnpm-workspace.yaml"], {
29+
projectName,
30+
}),
2931
};
3032
};

create-devcontainer/configs/base/index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ export type BaseConfigs = BaseDevcontainerConfigs & BaseDotConfigs & BaseWorkspa
99

1010
export const createBaseConfigs = async (projectName: string, remoteUser = "dev"): Promise<BaseConfigs> => {
1111
const devcontainerConfigs = await createBaseDevcontainerConfigs(projectName, remoteUser);
12-
const dotConfigs = await createBaseDotConfigs(remoteUser);
12+
const dotConfigs = await createBaseDotConfigs(projectName, remoteUser);
1313
const workspaceConfigs = await createBaseWorkspaceConfigs();
1414
return {
1515
...devcontainerConfigs,

create-devcontainer/templates/base/.config/workspaces/package.json

Lines changed: 0 additions & 4 deletions
This file was deleted.
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
packages:
2+
- "${projectName}/**"

0 commit comments

Comments
 (0)