From 18129ef4edc6ee71f60944a25f9ef0c308d71a87 Mon Sep 17 00:00:00 2001
From: Claude <noreply@anthropic.com>
Date: Sun, 19 Jul 2026 06:46:18 +0000
Subject: [PATCH] Sort Features with more user-defined options first, per spec

The Features spec's "Installation Order" rules state that Features in a
round are sorted by "Greatest number of user-defined options", but
optionsCompareTo compared option counts ascending, installing the
Feature with the fewest options first.

Flip the length comparison so the Feature with the greatest number of
options sorts first, and update the round-sorting test expectations
accordingly. Equal-length option sets still tie-break by key/value
comparison as before.
---
 src/spec-configuration/containerFeaturesOrder.ts          | 2 +-
 .../container-features/containerFeaturesOrder.test.ts     | 8 ++++----
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/spec-configuration/containerFeaturesOrder.ts b/src/spec-configuration/containerFeaturesOrder.ts
index 18f449a0a..918dbe280 100644
--- a/src/spec-configuration/containerFeaturesOrder.ts
+++ b/src/spec-configuration/containerFeaturesOrder.ts
@@ -121,7 +121,7 @@ function optionsCompareTo(a: string | boolean | Record<string, string | boolean
 		const aKeys = Object.keys(a);
 		const bKeys = Object.keys(b);
 		if (aKeys.length !== bKeys.length) {
-			return aKeys.length - bKeys.length;
+			return bKeys.length - aKeys.length;
 		}
 
 		aKeys.sort();
diff --git a/src/test/container-features/containerFeaturesOrder.test.ts b/src/test/container-features/containerFeaturesOrder.test.ts
index 8426a0946..5cd93bd55 100644
--- a/src/test/container-features/containerFeaturesOrder.test.ts
+++ b/src/test/container-features/containerFeaturesOrder.test.ts
@@ -154,10 +154,6 @@ describe('Feature Dependencies', function () {
             assert.deepStrictEqual(actual.length, 9);
             assert.deepStrictEqual(actual,
                 [
-                    {
-                        userFeatureId: './b',
-                        options: {}
-                    },
                     {
                         userFeatureId: './b',
                         options: {
@@ -186,6 +182,10 @@ describe('Feature Dependencies', function () {
                             optB: 'b'
                         }
                     },
+                    {
+                        userFeatureId: './b',
+                        options: {}
+                    },
                     {
                         userFeatureId: './d',
                         options: {}