Skip to content
This repository was archived by the owner on Mar 10, 2019. It is now read-only.

Commit 9e7593f

Browse files
devgianludevgianlu
committed
Send auth config to client
1 parent 91cb901 commit 9e7593f

7 files changed

Lines changed: 128 additions & 45 deletions

File tree

‎WebContent/index.js‎

Lines changed: 66 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -148,47 +148,67 @@ class LoginManager {
148148
})
149149
}
150150

151-
setupGoogle() {
152-
gapi.load('auth2', () => {
153-
this.google_auth2 = gapi.auth2.init({
154-
client_id: '464424051073-loi5kmcc3qev5a1lr5hvrjiqb3kcu2cl.apps.googleusercontent.com',
155-
cookiepolicy: 'single_host_origin',
156-
});
151+
setupGoogle(appId) {
152+
if (appId === undefined) {
153+
this.googleSignIn.hide();
154+
} else {
155+
this.googleSignIn.show();
156+
gapi.load('auth2', () => {
157+
this.google_auth2 = gapi.auth2.init({
158+
client_id: appId,
159+
cookiepolicy: 'single_host_origin',
160+
});
157161

158-
this.google_auth2.attachClickHandler(this.googleSignIn[0], {},
159-
(user) => this._googleSuccess(user),
160-
(error) => Notifier.error("Failed signing in with Google.", error));
161-
});
162+
this.google_auth2.attachClickHandler(this.googleSignIn[0], {},
163+
(user) => this._googleSuccess(user),
164+
(error) => Notifier.error("Failed signing in with Google.", error));
165+
});
166+
}
162167
}
163168

164-
setupFacebook() {
165-
FB.init({
166-
appId: '198497240899387',
167-
cookie: true,
168-
xfbml: true,
169-
autoLogAppEvents: Notifier._debug,
170-
version: 'v2.12'
171-
});
169+
setupFacebook(appId) {
170+
if (appId === undefined) {
171+
this.facebookSignIn.hide();
172+
} else {
173+
FB.init({
174+
appId: appId,
175+
cookie: true,
176+
xfbml: true,
177+
autoLogAppEvents: Notifier._debug,
178+
version: 'v2.12'
179+
});
172180

173-
FB.AppEvents.logPageView();
181+
FB.AppEvents.logPageView();
174182

175-
this.facebookSignIn.on('click', () => FB.login((user) => {
176-
this._facebookSuccess(user);
177-
}, {
178-
scope: 'email,public_profile',
179-
}));
183+
this.facebookSignIn.show();
184+
this.facebookSignIn.on('click', () => FB.login((user) => {
185+
this._facebookSuccess(user);
186+
}, {
187+
scope: 'email,public_profile',
188+
}));
189+
}
180190
}
181191

182-
setupGitHub() {
183-
this.githubSignIn.on('click', () => {
184-
window.location = "https://github.com/login/oauth/authorize?scope=read:user,user:email&client_id=d7057c607cf69f592239"
185-
})
192+
setupGitHub(appId) {
193+
if (appId === undefined) {
194+
this.githubSignIn.hide();
195+
} else {
196+
this.githubSignIn.show();
197+
this.githubSignIn.on('click', () => {
198+
window.location = "https://github.com/login/oauth/authorize?scope=read:user,user:email&client_id=" + appId
199+
})
200+
}
186201
}
187202

188-
setupTwitter() {
189-
this.twitterSignIn.on('click', () => {
190-
window.location = "/TwitterStartAuthFlow"
191-
})
203+
setupTwitter(appId) {
204+
if (appId === undefined) {
205+
this.twitterSignIn.hide();
206+
} else {
207+
this.twitterSignIn.show();
208+
this.twitterSignIn.on('click', () => {
209+
window.location = "/TwitterStartAuthFlow"
210+
})
211+
}
192212
}
193213

194214
_showNickDialog(params, success) {
@@ -354,6 +374,13 @@ class LoginManager {
354374

355375
setup() {
356376
Requester.request("fl", {}, (data) => {
377+
/**
378+
* @param {object} data.aC - Auth config
379+
* @param {string} data.aC.g - Google app id
380+
* @param {string} data.aC.fb - Facebook app id
381+
* @param {string} data.aC.gh - Github app id
382+
* @param {string} data.aC.tw - Twitter app id
383+
*/
357384
data.css.sort(function (a, b) {
358385
return a.w - b.w;
359386
});
@@ -368,10 +395,13 @@ class LoginManager {
368395
window.location = "/games/";
369396
}
370397
} else {
371-
this.setupGoogle();
372-
this.setupFacebook();
373-
this.setupGitHub();
374-
this.setupTwitter();
398+
const authConfig = data.aC;
399+
this.setupGoogle(authConfig.g);
400+
this.setupFacebook(authConfig.fb);
401+
this.setupGitHub(authConfig.gh);
402+
this.setupTwitter(authConfig.tw);
403+
404+
Notifier.debug(authConfig);
375405

376406
switch (getURLParameter("aT")) {
377407
case "gh":

‎src/main/java/com/gianlu/pyxreloaded/Consts.java‎

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -706,7 +706,11 @@ public enum GeneralKeys implements ReceivableKey, ReturnableKey {
706706
/**
707707
* User account data.
708708
*/
709-
ACCOUNT("a");
709+
ACCOUNT("a"),
710+
/**
711+
* Authentication configuration for client.
712+
*/
713+
AUTH_CONFIG("aC");
710714

711715
private final String key;
712716

@@ -1133,7 +1137,7 @@ public String toString() {
11331137
/**
11341138
* Identify auth type in database, also used to send authentication data
11351139
*/
1136-
public enum AuthType implements ReceivableKey {
1140+
public enum AuthType implements ReceivableKey, ReturnableKey {
11371141
@IgnoreDuplicateIn(GameOptionsData.class)
11381142
PASSWORD("pw"),
11391143
GOOGLE("g"),

‎src/main/java/com/gianlu/pyxreloaded/handlers/FirstLoadHandler.java‎

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
import com.gianlu.pyxreloaded.server.Parameters;
1010
import com.gianlu.pyxreloaded.singletons.LoadedCards;
1111
import com.gianlu.pyxreloaded.singletons.Preferences;
12+
import com.gianlu.pyxreloaded.singletons.SocialLogin;
1213
import com.google.gson.JsonArray;
1314
import io.undertow.server.HttpServerExchange;
1415

@@ -17,10 +18,12 @@
1718
public class FirstLoadHandler extends BaseHandler {
1819
public static final String OP = Consts.Operation.FIRST_LOAD.toString();
1920
private final LoadedCards loadedCards;
21+
private final SocialLogin socials;
2022
private final Preferences preferences;
2123

22-
public FirstLoadHandler(@Annotations.LoadedCards LoadedCards loadedCards, @Annotations.Preferences Preferences preferences) {
24+
public FirstLoadHandler(@Annotations.LoadedCards LoadedCards loadedCards, @Annotations.SocialLogin SocialLogin socials, @Annotations.Preferences Preferences preferences) {
2325
this.loadedCards = loadedCards;
26+
this.socials = socials;
2427
this.preferences = preferences;
2528
}
2629

@@ -45,6 +48,15 @@ public JsonWrapper handle(User user, Parameters params, HttpServerExchange excha
4548
}
4649
}
4750

51+
// TODO: Is password login enabled?
52+
53+
JsonWrapper socialsConfig = new JsonWrapper();
54+
if (socials.googleEnabled()) socialsConfig.add(Consts.AuthType.GOOGLE, socials.googleAppId());
55+
if (socials.facebookEnabled()) socialsConfig.add(Consts.AuthType.FACEBOOK, socials.facebookAppId());
56+
if (socials.githubEnabled()) socialsConfig.add(Consts.AuthType.GITHUB, socials.githubAppId());
57+
if (socials.twitterEnabled()) socialsConfig.add(Consts.AuthType.TWITTER, socials.twitterAppId());
58+
obj.add(Consts.GeneralKeys.AUTH_CONFIG, socialsConfig);
59+
4860
Set<PyxCardSet> cardSets = loadedCards.getLoadedSets();
4961
JsonArray json = new JsonArray(cardSets.size());
5062
for (PyxCardSet cardSet : cardSets) json.add(cardSet.getClientMetadataJson().obj());

‎src/main/java/com/gianlu/pyxreloaded/singletons/SocialLogin.java‎

Lines changed: 28 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -33,21 +33,23 @@ public final class SocialLogin {
3333
private final TwitterAuthHelper twitterHelper;
3434
private final GoogleIdTokenVerifier googleHelper;
3535
private final FacebookAuthHelper facebookHelper;
36+
private final String googleAppId;
3637

3738
public SocialLogin(@Nullable GithubAuthHelper githubHelper, @Nullable TwitterAuthHelper twitterHelper, @Nullable FacebookAuthHelper facebookHelper, Preferences preferences) {
3839
this.githubHelper = githubHelper;
3940
this.twitterHelper = twitterHelper;
4041
this.facebookHelper = facebookHelper;
41-
this.googleHelper = instantiateGoogleHelper(preferences);
42+
43+
this.googleAppId = preferences.getString("socials/googleClientId", null);
44+
this.googleHelper = instantiateGoogleHelper(googleAppId);
4245
}
4346

47+
@Contract("null -> null")
4448
@Nullable
45-
private static GoogleIdTokenVerifier instantiateGoogleHelper(Preferences preferences) {
46-
String clientId = preferences.getString("socials/googleClientId", null);
47-
if (clientId == null || clientId.isEmpty()) return null;
48-
49+
private static GoogleIdTokenVerifier instantiateGoogleHelper(String appId) {
50+
if (appId == null || appId.isEmpty()) return null;
4951
return new GoogleIdTokenVerifier.Builder(new ApacheHttpTransport(), new JacksonFactory())
50-
.setAudience(Collections.singletonList(clientId))
52+
.setAudience(Collections.singletonList(appId))
5153
.build();
5254
}
5355

@@ -124,18 +126,38 @@ public boolean googleEnabled() {
124126
return googleHelper != null;
125127
}
126128

129+
@Nullable
130+
public String googleAppId() {
131+
return googleAppId;
132+
}
133+
127134
@Contract(pure = true)
128135
public boolean facebookEnabled() {
129136
return facebookHelper != null;
130137
}
131138

139+
@Nullable
140+
public String facebookAppId() {
141+
return facebookHelper == null ? null : facebookHelper.appId();
142+
}
143+
132144
@Contract(pure = true)
133145
public boolean githubEnabled() {
134146
return githubHelper != null;
135147
}
136148

149+
@Nullable
150+
public String githubAppId() {
151+
return githubHelper == null ? null : githubHelper.appId();
152+
}
153+
137154
@Contract(pure = true)
138155
public boolean twitterEnabled() {
139156
return twitterHelper != null;
140157
}
158+
159+
@Nullable
160+
public String twitterAppId() {
161+
return twitterHelper == null ? null : twitterHelper.appId();
162+
}
141163
}

‎src/main/java/com/gianlu/pyxreloaded/socials/facebook/FacebookAuthHelper.java‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,11 @@ public static FacebookAuthHelper instantiate(Preferences preferences) {
4141
return new FacebookAuthHelper(appId, appSecret);
4242
}
4343

44+
@NotNull
45+
public String appId() {
46+
return appId;
47+
}
48+
4449
@Nullable
4550
public FacebookToken verify(@NotNull String accessToken) throws IOException, FacebookOAuthException {
4651
HttpGet get = new HttpGet(DEBUG_TOKEN + "?input_token=" + accessToken + "&access_token=" + appToken);

‎src/main/java/com/gianlu/pyxreloaded/socials/github/GithubAuthHelper.java‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -130,4 +130,9 @@ public String exchangeCode(@NotNull String code) throws IOException, GithubExcep
130130
post.releaseConnection();
131131
}
132132
}
133+
134+
@NotNull
135+
public String appId() {
136+
return appId;
137+
}
133138
}

‎src/main/java/com/gianlu/pyxreloaded/socials/twitter/TwitterAuthHelper.java‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -83,6 +83,11 @@ public TwitterProfileInfo info(OAuth1AccessToken token) throws InterruptedExcept
8383
}
8484
}
8585

86+
@NotNull
87+
public String appId() {
88+
return service.getConfig().getApiKey();
89+
}
90+
8691
private static class HttpClientWrapper implements HttpClient {
8792
private final CloseableHttpClient client;
8893

0 commit comments

Comments
 (0)