fix(cast): correct boolify function to handle string conversions properly

Author: wilcorrea

src/_/cast.php

@@ -7,6 +7,7 @@
 use Stringable;
 
 use function function_exists;
+use function in_array;
 use function is_array;
 use function is_bool;
 use function is_float;
@@ -17,6 +18,7 @@
 use function is_string;
 use function method_exists;
 use function sprintf;
+use function strtolower;
 
 if (! function_exists(__NAMESPACE__ . '\arrayify')) {
     /**
@@ -96,11 +98,26 @@ function floatify(mixed $value, float $default = 0.0): float
 if (! function_exists(__NAMESPACE__ . '\boolify')) {
     function boolify(mixed $value, bool $default = false): bool
     {
+        $positive = [
+            '1',
+            'true',
+            'on',
+            'yes',
+            'y',
+        ];
+        $negative = [
+            '0',
+            'false',
+            'off',
+            'no',
+            'n',
+            '',
+        ];
         return match (true) {
             is_bool($value) => $value,
             is_numeric($value) => (bool) $value,
-            is_string($value) && ($value === 'true' || $value === '1') => true,
-            is_string($value) && ($value === 'false' || $value === '1') => false,
+            is_string($value) && in_array(strtolower($value), $positive, true) => true,
+            is_string($value) && in_array(strtolower($value), $negative, true) => false,
             default => $default,
         };
     }

tests/_/CastFunctionsTest.php

@@ -64,17 +64,49 @@ public function testToIntReturnsDefaultWhenValueIsNotInt(): void
 
     public function testToBoolReturnsBoolWhenValueIsBool(): void
     {
-        $value = true;
-        $result = boolify($value);
-        $this->assertEquals($value, $result);
+        $result = boolify(true);
+        $this->assertTrue($result);
     }
 
     public function testToBoolReturnsDefaultWhenValueIsNotBool(): void
     {
         $value = 'not a bool';
-        $default = true;
-        $result = boolify($value, $default);
-        $this->assertEquals(true, $result);
+        $result = boolify($value, true);
+        $this->assertTrue($result);
+    }
+
+    public function testBoolifyParsesStringPositives(): void
+    {
+        $this->assertTrue(boolify('1'));
+        $this->assertTrue(boolify('true'));
+        $this->assertTrue(boolify('TRUE'));
+        $this->assertTrue(boolify('on'));
+        $this->assertTrue(boolify('ON'));
+        $this->assertTrue(boolify('yes'));
+        $this->assertTrue(boolify('Y'));
+        $this->assertTrue(boolify('yEs'));
+    }
+
+    public function testBoolifyParsesStringNegatives(): void
+    {
+        $this->assertFalse(boolify('0'));
+        $this->assertFalse(boolify('false'));
+        $this->assertFalse(boolify('FALSE'));
+        $this->assertFalse(boolify('off'));
+        $this->assertFalse(boolify('OFF'));
+        $this->assertFalse(boolify('no'));
+        $this->assertFalse(boolify('n'));
+        $this->assertFalse(boolify(''));
+    }
+
+    public function testBoolifyHandlesNumericValues(): void
+    {
+        $this->assertTrue(boolify(1));
+        $this->assertFalse(boolify(0));
+        $this->assertTrue(boolify(10));
+        $this->assertTrue(boolify(-3));
+        $this->assertTrue(boolify('2'));
+        $this->assertFalse(boolify('0'));
     }
 
     public function testFloatifyReturnsFloatWhenValueIsFloat(): void
@@ -113,21 +145,38 @@ public function testMapifyConvertsObjectToArray(): void
         $object->name = 'John';
         $object->age = 30;
         $result = mapify($object);
-        $this->assertEquals(['name' => 'John', 'age' => 30], $result);
+        $this->assertEquals(
+            [
+                'name' => 'John',
+                'age' => 30,
+            ],
+            $result
+        );
     }
 
     public function testMapifyReturnsArrayWhenValueIsArray(): void
     {
-        $array = ['key' => 'value', 'number' => 42];
+        $array = [
+            'key' => 'value',
+            'number' => 42,
+        ];
         $result = mapify($array);
         $this->assertEquals($array, $result);
     }
 
     public function testMapifyHandlesNumericKeys(): void
     {
-        $array = [0 => 'first', 1 => 'second', 'name' => 'test'];
+        $array = [
+            0 => 'first',
+            1 => 'second',
+            'name' => 'test',
+        ];
         $result = mapify($array);
-        $expected = ['key_0' => 'first', 'key_1' => 'second', 'name' => 'test'];
+        $expected = [
+            'key_0' => 'first',
+            'key_1' => 'second',
+            'name' => 'test',
+        ];
         $this->assertEquals($expected, $result);
     }