fix: apply linter suggestions

Author: wilcorrea

src/Support/Metadata/Schema.php

@@ -46,7 +46,9 @@ public function get(string $name): Field
      */
     public function rules(): array
     {
-        return array_map(fn (Field $field) => $field->rules(), $this->available());
+        $callback = fn (Field $field) => $field->rules();
+        $rules = $this->available();
+        return array_map($callback, $rules);
     }
 
     /**
@@ -65,6 +67,9 @@ public function mappings(): array
         return $mappings;
     }
 
+    /**
+     * @return array<string, Field>
+     */
     private function available(): array
     {
         return $this->fieldset->filter(fn (Field $field) => $field->isAvailable());

src/Support/Metadata/Schema/Field.php

@@ -112,6 +112,10 @@ final class Field
     private bool $available = true;
 
     private Closure|string|null $map = null;
+
+    /**
+     * @var class-string<object>|null
+     */
     private ?string $source = null;
 
     public function __construct(
@@ -121,6 +125,9 @@ public function __construct(
     ) {
     }
 
+    /**
+     * @return array<string>
+     */
     public function rules(): array
     {
         return $this->rules->all();
@@ -136,11 +143,17 @@ public function isAvailable(): bool
         return $this->available;
     }
 
+    /**
+     * @param class-string<object> $source
+     */
     public function setSource(string $source): void
     {
         $this->source = $source;
     }
 
+    /**
+     * @return class-string<object>|null
+     */
     public function getSource(): ?string
     {
         return $this->source;
@@ -174,9 +187,11 @@ private function is(array $haystack, string $needle): bool
         return in_array($needle, $haystack, true);
     }
 
-    private function handleMapping(Closure|string $map): void
+    private function handleMapping(mixed $mapping): void
     {
-        $this->map = $map;
+        if ($mapping instanceof Closure || is_string($mapping)) {
+            $this->map = $mapping;
+        }
     }
 
     private function handleVisibility(string $name): void

src/Support/Metadata/Schema/Field/Fieldset.php

@@ -29,8 +29,19 @@ public function has(string $name): bool
         return array_key_exists($name, $this->fields);
     }
 
+    /**
+     * @return array<string, Field>
+     */
     public function filter(Closure $criteria): array
     {
         return array_filter($this->fields, $criteria);
     }
+
+    /**
+     * @return array<string, Field>
+     */
+    public function all(): array
+    {
+        return $this->fields;
+    }
 }

src/Support/Metadata/Schema/Field/Formatter/PatternFormatter.php

@@ -12,7 +12,7 @@
 use function Constructo\Cast\stringify;
 use function count;
 use function is_array;
-use function sprintf;
+use function vsprintf;
 
 class PatternFormatter implements Formatter
 {
@@ -39,9 +39,29 @@ public function formatWithParameters(array $value): array
         if ($parameters === null) {
             $parameters = [];
         }
+        $parameters = $this->normalizeParameters($parameters);
+        return [vsprintf(stringify($pattern), $parameters)];
+    }
+
+    /**
+     * @return array<bool|float|int|string|null>
+     */
+    public function normalizeParameters(mixed $parameters): array
+    {
         if ($parameters instanceof Closure) {
             $parameters = arrayify($parameters());
         }
-        return [sprintf(stringify($pattern), ...$parameters)];
+        if (! is_array($parameters)) {
+            $parameters = [$parameters];
+        }
+
+        $normalizer = fn (mixed $value) => match (true) {
+            is_bool($value) => $value,
+            is_int($value) => $value,
+            is_float($value) => $value,
+            is_string($value) => $value,
+            default => null
+        };
+        return array_map($normalizer, $parameters);
     }
 }

src/Support/Metadata/Schema/Field/Rule.php

@@ -10,6 +10,7 @@
 
 use function Constructo\Cast\arrayify;
 use function Constructo\Cast\stringify;
+use function is_string;
 use function sprintf;
 
 readonly class Rule implements Stringable, JsonSerializable
@@ -20,7 +21,11 @@ public function __construct(
         public Spec $spec,
         public array $arguments = [],
     ) {
-        $this->key = $spec->properties->get('kind') ?? $spec->name;
+        $kind = $spec->properties->get('kind');
+        if (! is_string($kind)) {
+            $kind = null;
+        }
+        $this->key = $kind ?? $spec->name;
     }
 
     public function __toString(): string
@@ -48,7 +53,12 @@ private function enforce(mixed $item): string
             is_string($item) => $item,
             is_iterable($item) => implode(
                 ',',
-                array_map(fn (mixed $element): string => $this->enforce($element), $item)
+                array_map(
+                    fn ($element): string => $this->enforce($element),
+                    is_array($item)
+                        ? $item
+                        : iterator_to_array($item)
+                )
             ),
             default => stringify($item),
         };

src/Support/Metadata/Schema/Field/Rules.php

@@ -14,11 +14,19 @@
 
 class Rules
 {
+    /**
+     * @var array<string, Rule>
+     */
     private array $rules = [];
 
+    /**
+     * @return array<string>
+     */
     public function all(): array
     {
-        return array_map(fn (Rule $rule): string => stringify($rule), array_values($this->rules));
+        $callback = fn (mixed $rule): string => stringify($rule);
+        $rules = array_values($this->rules);
+        return array_map($callback, $rules);
     }
 
     public function register(Spec $spec, array $arguments): void