feat(collection): return existing collection instance when already resolved

Author: wilcorrea

src/Core/Serialize/Resolver/CollectionValue.php

@@ -37,6 +37,10 @@ public function resolve(ReflectionParameter $parameter, Set $set): Value
      */
     private function resolveCollection(string $collectionName, mixed $value): Value
     {
+        if ($value instanceof $collectionName) {
+            return new Value($value);
+        }
+
         $reflection = new ReflectionClass($collectionName);
         $type = $this->detectCollectionType($reflection);
 
@@ -45,6 +49,15 @@ private function resolveCollection(string $collectionName, mixed $value): Value
         if ($type === null || ! is_array($value)) {
             return new Value($collection);
         }
+        return $this->populateCollection($collection, $type, $value);
+    }
+
+    /**
+     * @param class-string $type
+     * @param array<mixed> $value
+     */
+    private function populateCollection(Collectable $collection, string $type, array $value): Value
+    {
         foreach ($value as $datum) {
             $datum = arrayify($datum);
             $set = Set::createFrom($datum);

tests/Core/Serialize/Resolver/CollectionValueTest.php

@@ -94,4 +94,32 @@ public function testShouldResolveCollectionWithArrayData(): void
         $this->assertInstanceOf(FeatureCollection::class, $result->content);
         $this->assertCount(2, $result->content);
     }
+
+    public function testShouldReturnSameCollectionWhenValueIsAlreadyCollectionInstance(): void
+    {
+        // Arrange
+        $type = $this->createMock(ReflectionNamedType::class);
+        $type->expects($this->once())
+            ->method('getName')
+            ->willReturn(FeatureCollection::class);
+        $parameter = $this->createMock(ReflectionParameter::class);
+        $parameter->expects($this->once())
+            ->method('getType')
+            ->willReturn($type);
+        $parameter->expects($this->once())
+            ->method('getName')
+            ->willReturn('features');
+
+        $existingCollection = new FeatureCollection();
+        $set = Set::createFrom([
+            'features' => $existingCollection,
+        ]);
+        $collectionValue = new CollectionValue();
+
+        // Act
+        $result = $collectionValue->resolve($parameter, $set);
+
+        // Assert
+        $this->assertSame($existingCollection, $result->content);
+    }
 }