Restart scheduler when viewer is added or removed (#697)

Author: devnatan

inventory-framework-api/src/main/java/me/devnatan/inventoryframework/pipeline/StandardPipelinePhases.java

@@ -59,6 +59,10 @@ private StandardPipelinePhases() {}
      */
     public static final PipelinePhase INVALIDATION = new PipelinePhase("invalidation");
 
+    public static final PipelinePhase VIEWER_ADDED = new PipelinePhase("viewer-added");
+
+    public static final PipelinePhase VIEWER_REMOVED = new PipelinePhase("viewer-removed");
+
     /**
      * Called during layout resolution phase before {@link #FIRST_RENDER} phase.
      * In this pipeline phase the pipeline interceptor subject is a {@link IFRenderContext}.

inventory-framework-core/src/main/java/me/devnatan/inventoryframework/component/PaginationImpl.java

@@ -140,7 +140,6 @@ private CompletableFuture<List<?>> loadSourceForTheCurrentPage() {
         isLoading = true;
         simulateStateUpdate();
 
-        // TODO Do some error treatment here, even if we expect to the user to handle it
         return createProvidedNewSource().handle((result, exception) -> {
             if (exception != null) {
                 debug("[Pagination] An error occurred on data source computation: %s", exception.getMessage());

…heduledUpdateAfterRenderInterceptor.java …ine/ScheduledUpdateStartInterceptor.javainventory-framework-core/src/main/java/me/devnatan/inventoryframework/pipeline/ScheduledUpdateAfterRenderInterceptor.java renamed to inventory-framework-core/src/main/java/me/devnatan/inventoryframework/pipeline/ScheduledUpdateStartInterceptor.java inventory-framework-core/src/main/java/me/devnatan/inventoryframework/pipeline/ScheduledUpdateAfterRenderInterceptor.java renamed to inventory-framework-core/src/main/java/me/devnatan/inventoryframework/pipeline/ScheduledUpdateStartInterceptor.java

@@ -8,7 +8,7 @@
 import me.devnatan.inventoryframework.context.IFRenderContext;
 import me.devnatan.inventoryframework.internal.Job;
 
-public final class ScheduledUpdateAfterRenderInterceptor implements PipelineInterceptor<VirtualView> {
+public final class ScheduledUpdateStartInterceptor implements PipelineInterceptor<VirtualView> {
 
     @Override
     public void intercept(PipelineContext<VirtualView> pipeline, VirtualView subject) {

…cheduledUpdateAfterCloseInterceptor.java …line/ScheduledUpdateStopInterceptor.javainventory-framework-core/src/main/java/me/devnatan/inventoryframework/pipeline/ScheduledUpdateAfterCloseInterceptor.java renamed to inventory-framework-core/src/main/java/me/devnatan/inventoryframework/pipeline/ScheduledUpdateStopInterceptor.java inventory-framework-core/src/main/java/me/devnatan/inventoryframework/pipeline/ScheduledUpdateAfterCloseInterceptor.java renamed to inventory-framework-core/src/main/java/me/devnatan/inventoryframework/pipeline/ScheduledUpdateStopInterceptor.java

@@ -5,7 +5,7 @@
 import me.devnatan.inventoryframework.context.IFCloseContext;
 import me.devnatan.inventoryframework.context.IFContext;
 
-public final class ScheduledUpdateAfterCloseInterceptor implements PipelineInterceptor<VirtualView> {
+public final class ScheduledUpdateStopInterceptor implements PipelineInterceptor<VirtualView> {
 
     @Override
     public void intercept(PipelineContext<VirtualView> pipeline, VirtualView subject) {

inventory-framework-platform/src/main/java/me/devnatan/inventoryframework/PlatformView.java

@@ -34,8 +34,8 @@
 import me.devnatan.inventoryframework.pipeline.PlatformOpenInterceptor;
 import me.devnatan.inventoryframework.pipeline.PlatformRenderInterceptor;
 import me.devnatan.inventoryframework.pipeline.PlatformUpdateHandlerInterceptor;
-import me.devnatan.inventoryframework.pipeline.ScheduledUpdateAfterCloseInterceptor;
-import me.devnatan.inventoryframework.pipeline.ScheduledUpdateAfterRenderInterceptor;
+import me.devnatan.inventoryframework.pipeline.ScheduledUpdateStartInterceptor;
+import me.devnatan.inventoryframework.pipeline.ScheduledUpdateStopInterceptor;
 import me.devnatan.inventoryframework.pipeline.StandardPipelinePhases;
 import me.devnatan.inventoryframework.pipeline.UpdateInterceptor;
 import me.devnatan.inventoryframework.pipeline.ViewerLastInteractionTrackerInterceptor;
@@ -601,11 +601,11 @@ final void internalInitialization(IFViewFrame<?, ?> framework) {
         pipeline.intercept(StandardPipelinePhases.FIRST_RENDER, new LayoutRenderInterceptor());
         pipeline.intercept(StandardPipelinePhases.FIRST_RENDER, new AvailableSlotInterceptor());
         pipeline.intercept(StandardPipelinePhases.FIRST_RENDER, new FirstRenderInterceptor());
-        pipeline.intercept(StandardPipelinePhases.FIRST_RENDER, new ScheduledUpdateAfterRenderInterceptor());
+        pipeline.intercept(StandardPipelinePhases.VIEWER_ADDED, new ScheduledUpdateStartInterceptor());
+        pipeline.intercept(StandardPipelinePhases.VIEWER_REMOVED, new ScheduledUpdateStopInterceptor());
         pipeline.intercept(StandardPipelinePhases.UPDATE, new PlatformUpdateHandlerInterceptor());
         pipeline.intercept(StandardPipelinePhases.UPDATE, new UpdateInterceptor());
         pipeline.intercept(StandardPipelinePhases.CLOSE, new PlatformCloseInterceptor());
-        pipeline.intercept(StandardPipelinePhases.CLOSE, new ScheduledUpdateAfterCloseInterceptor());
         pipeline.intercept(StandardPipelinePhases.CLOSE, new ContextInvalidationOnCloseInterceptor());
         pipeline.intercept(StandardPipelinePhases.CLICK, new ViewerLastInteractionTrackerInterceptor());
         pipeline.intercept(StandardPipelinePhases.CLICK, new ComponentClickHandlerCallInterceptor());

inventory-framework-platform/src/main/java/me/devnatan/inventoryframework/pipeline/ContextInvalidationOnCloseInterceptor.java

@@ -23,6 +23,7 @@ public void intercept(PipelineContext<VirtualView> pipeline, VirtualView subject
         final PlatformView root = (PlatformView) context.getRoot();
         final Viewer viewer = context.getViewer();
         root.onViewerRemoved(context.getParent(), viewer.getPlatformInstance());
+        root.getPipeline().execute(StandardPipelinePhases.VIEWER_REMOVED, subject);
         root.removeAndTryInvalidateContext(viewer, context);
     }
 }

inventory-framework-platform/src/main/java/me/devnatan/inventoryframework/pipeline/PlatformOpenInterceptor.java

@@ -90,6 +90,7 @@ IFRenderContext createRenderContext(IFOpenContext openContext) {
             if (!viewer.isTransitioning()) viewer.setActiveContext(renderContext);
             // TODO Pass viewer object as parameter instead
             root.onViewerAdded(renderContext, viewer.getPlatformInstance(), renderContext.getInitialData());
+            root.getPipeline().execute(StandardPipelinePhases.VIEWER_ADDED, renderContext);
             renderContext.addViewer(viewer);
         }