feat(*): code cleanup and simplification

Author: devnote-dev

src/commands/base.cr

@@ -111,6 +111,10 @@ module Geode::Commands
       exit_program
     end
 
+    protected def puts : Nil
+      stdout.puts
+    end
+
     protected def puts(msg : String) : Nil
       stdout.puts msg
     end

src/commands/init.cr

@@ -92,7 +92,7 @@ module Geode::Commands
         license = input
       end
 
-      stdout.puts
+      puts
       write_shard(name, description, author, version, crystal, license)
     end
 

src/commands/install.cr

@@ -87,8 +87,9 @@ module Geode::Commands
       shards = [] of Shard
       Dir.each_child("lib") do |child|
         next if child.starts_with? '.'
-        next unless File.exists?(path = Path["lib"] / child / "shard.yml")
-        shards << Shard.from_yaml File.read path
+        next unless Shard.exists? child
+
+        shards << Shard.load child
       rescue YAML::ParseException
         warn "Failed to parse shard.yml contents for '#{child}'"
       end

src/commands/licenses.cr

@@ -27,7 +27,7 @@ module Geode::Commands
       trigram = Trigram.new do |t|
         License.licenses.each { |l| t.add l.title }
       end
-      found = Hash(String, Array(License)).new # { [] of License }
+      found = Hash(String, Array(License)).new
 
       paths.each do |name, arr|
         licenses = [] of License
@@ -80,12 +80,11 @@ module Geode::Commands
 
       Dir.each_child("lib") do |child|
         next if child.starts_with? '.'
-        next unless File.exists?(path = Path["lib"] / child / "shard.yml")
+        next unless Shard.exists? child
 
-        shard = Shard.from_yaml File.read path
-        libs << shard.name
-      rescue YAML::ParseException
-        warn "Failed to parse shard.yml contents for '#{child}'"
+        libs << Shard.load(child).name
+      rescue Shard::Error
+        warn "Failed to parse shard.yml for '#{child}'"
       end
 
       libs

src/commands/watch.cr

@@ -15,34 +15,21 @@ module Geode::Commands
 
     def run(arguments : Cling::Arguments, options : Cling::Options) : Nil
       shard = Shard.load_local
-      if shard.targets.empty?
-        error "No targets defined in shard.yml"
-        exit_program
-      end
-
+      fatal "No targets defined in shard.yml" if shard.targets.empty?
       Dir.mkdir_p "bin"
 
       name = arguments.get?("target").try(&.as_s) || shard.targets.first_key
-      unless target = shard.targets[name]?
-        error "Unknown target '#{name}'"
-        exit_program
-      end
-
-      unless target.has_key? "main"
-        error "Missing 'main' field for target: #{name}"
-        exit_program
-      end
+      fatal "Unknown target '#{name}'" unless target = shard.targets[name]?
+      fatal "Missing 'main' field for target: #{name}" unless target.has_key? "main"
 
       begin
-        interval = options.get("interval").as_f
+        interval = options.get("interval").to_f64
       rescue
-        error "Could not parse interval (must be a number)"
-        exit_program
+        fatal "Could not parse interval (must be a number)"
       end
 
       unless old_stamps = get_timestamps
-        error "No Crystal files found to watch"
-        exit_program
+        fatal "No Crystal files found to watch"
       end
 
       dry = options.has? "dry"
@@ -102,7 +89,7 @@ module Geode::Commands
       loop do
         break unless count = sig.receive?
         if proc.exists?
-          stdout.puts if pipe
+          puts if pipe
           info "Cancelling build"
           proc.terminate
         end