ci(deploy-cp): run STONITH verify last, after the agent relaunch#135
Merged
Conversation
The relaunch cascade itself triggers a second wave of STONITH activity: the tdx2 agent re-registers with the fresh CP, its old CF tunnel is deleted, and the old CP's self-watchdog then poweroffs. Verifying after the relaunch captures that wave — the previous position verified only the kill that happens when the new CP first registers its own tunnel. Also reorders user-facing deliverables (PR comment, local agent back online) ahead of the slowest + flakiest check (24×5s loop with a fallback `gcloud delete`), so those land first. No behavior change on the happy path. If relaunch fails, the STONITH verification no longer runs — but operator attention is already needed in that case, and the old VMs self-terminate via the CF-tunnel-delete trigger at register time either way. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
DD preview readyURL: https://pr-135.devopsdefender.com Browser login: paste CLI / curl: Register endpoint for a local agent: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
No behavior change on the happy path.
Scope boundary
If relaunch fails, STONITH verification no longer runs (it used to). Acceptable — old VMs already self-terminate via the CF-tunnel-delete trigger at register time, and operator attention is needed on relaunch failures anyway.
Test plan
🤖 Generated with Claude Code