Fix/consolidated security and error handling (#38)

edgardevo · web-flow · commit ae0a181068ce · 2026-03-25T15:58:38.000+01:00
* feat: improve error handling and validation

* build: update pre-commit configuration from example

* ci: update pre-commit workflow and apply automatic fixes
diff --git a/.github/workflows/pre-commit.yml b/.github/workflows/pre-commit.yml
@@ -1,24 +1,18 @@
-name: pre-commits CI
+name: pre-commit
 
 on:
-  push:
-    paths:
-      - dataform2looker/**
-      - tests/**
-      - .pre-commit-config.yaml
   pull_request:
-    branches: [ "main" ]
+  push:
+    branches: [main]
 
 jobs:
-  test:
+  pre-commit:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
-      - name: Set up Python "3.10"
-        uses: actions/setup-python@v4
+      - uses: actions/setup-python@v5
         with:
           python-version: "3.10"
-      - name: Install pre-commit
-        run: pip install pre-commit
-      - name: Run pre-commit hooks
-        run: pre-commit run --all-files
+      - name: Install poetry
+        run: pipx install poetry
+      - uses: pre-commit/action@v3.0.1
diff --git a/.gitignore b/.gitignore
@@ -171,3 +171,4 @@ result.json
 .vscode/
 
 .DS_Store
+.envrc
diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
@@ -1,35 +1,45 @@
 repos:
   - repo: https://github.com/pre-commit/pre-commit-hooks
-    rev: v4.6.0
+    rev: v6.0.0
     hooks:
-      - id: check-added-large-files
+      - id: trailing-whitespace
+      - id: end-of-file-fixer
+      - id: check-toml
+      - id: check-merge-conflict
+      - id: check-ast
       - id: check-case-conflict
+      - id: check-docstring-first
       - id: check-json
-      - id: check-symlinks
       - id: check-yaml
-      - id: destroyed-symlinks
+      - id: debug-statements
       - id: detect-private-key
-      - id: end-of-file-fixer
-      - id: fix-byte-order-marker
-      - id: trailing-whitespace
       - id: mixed-line-ending
-        args: [--fix=auto]
       - id: pretty-format-json
-        args: [--autofix, --no-sort-keys]
+        args: [--autofix, --indent, "4"]
+  - repo: https://github.com/Lucas-C/pre-commit-hooks
+    rev: v1.5.5
+    hooks:
+      - id: remove-crlf
+      - id: forbid-crlf
+  - repo: https://github.com/adrienverge/yamllint
+    rev: v1.37.1
+    hooks:
+      - id: yamllint
+        args: ["-d {extends: relaxed, rules: {line-length: disable}}", "-s"]
   - repo: https://github.com/astral-sh/ruff-pre-commit
-    rev: v0.6.4
+    rev: v0.14.6
     hooks:
       - id: ruff
         args: [ --fix ]
       - id: ruff-format
   - repo: https://github.com/crate-ci/typos
-    rev: v1.24.5
+    rev: v1.39.2
     hooks:
       - id: typos
-  -   repo: https://github.com/python-poetry/poetry
-      rev: '1.8.3'
-      hooks:
-      -   id: poetry-check
-      -   id: poetry-lock
-      -   id: poetry-export
-      -   id: poetry-install
+  - repo: https://github.com/python-poetry/poetry
+    rev: '1.8.3'
+    hooks:
+      - id: poetry-check
+      - id: poetry-lock
+      - id: poetry-export
+      - id: poetry-install
diff --git a/dataform2looker/lookml.py b/dataform2looker/lookml.py
@@ -45,7 +45,7 @@ def __init__(
     def save_lookml_views(self) -> None:
         """Generates and saves LookML view files for each table."""  # noqa: E501
         for table_name, table_template in self.lookml_templates.items():
-            file_path = f"{self.target_folder_path}/" f"{table_name}.view.lkml"
+            file_path = f"{self.target_folder_path}/{table_name}.view.lkml"
             logging.debug(f"Creating file {file_path}")
             with open(file_path, "w") as f:
                 f.write(table_template)
diff --git a/tests/conftest.py b/tests/conftest.py
@@ -1,4 +1,4 @@
-"""Test configuraitons."""
+"""Test configurations."""
 
 from pytest import FixtureRequest, Parser, fixture
 
diff --git a/tests/dataform_result.json b/tests/dataform_result.json
@@ -1,58 +1,58 @@
 {
-  "tables": [
-    {
-      "type": "table",
-      "target": {
-        "schema": "chicago_taxi_trips",
-        "name": "taxi_trips",
-        "database": "bigquery-public-data"
-      },
-      "query": "\n\n SELECT 1 \n",
-      "disabled": false,
-      "fileName": "",
-      "tags": [
-        "tag1"
-      ],
-      "dependencyTargets": [],
-      "canonicalTarget": {
-        "schema": "chicago_taxi_trips",
-        "name": "taxi_trips",
-        "database": "bigquery-public-data"
-      },
-      "enumType": "TABLE"
+    "assertions": [],
+    "dataformCoreVersion": "3.0.0",
+    "declarations": [],
+    "graphErrors": {},
+    "projectConfig": {
+        "assertionSchema": "chicago_taxi_trips",
+        "defaultDatabase": "bigquery-public-data",
+        "defaultLocation": "EU",
+        "defaultSchema": "chicago_taxi_trips",
+        "warehouse": "bigquery"
     },
-    {
-      "type": "table",
-      "target": {
-        "schema": "chicago_crime",
-        "name": "crime",
-        "database": "bigquery-public-data"
-      },
-      "query": "\n\n SELECT 1 \n",
-      "disabled": false,
-      "fileName": "",
-      "tags": [
-        "tag2"
-      ],
-      "dependencyTargets": [],
-      "canonicalTarget": {
-        "schema": "chicago_crime",
-        "name": "crime",
-        "database": "bigquery-public-data"
-      },
-      "enumType": "TABLE"
-    }
-  ],
-  "assertions": [],
-  "projectConfig": {
-    "warehouse": "bigquery",
-    "defaultSchema": "chicago_taxi_trips",
-    "assertionSchema": "chicago_taxi_trips",
-    "defaultDatabase": "bigquery-public-data",
-    "defaultLocation": "EU"
-  },
-  "graphErrors": {},
-  "declarations": [],
-  "dataformCoreVersion": "3.0.0",
-  "targets": []
+    "tables": [
+        {
+            "canonicalTarget": {
+                "database": "bigquery-public-data",
+                "name": "taxi_trips",
+                "schema": "chicago_taxi_trips"
+            },
+            "dependencyTargets": [],
+            "disabled": false,
+            "enumType": "TABLE",
+            "fileName": "",
+            "query": "\n\n SELECT 1 \n",
+            "tags": [
+                "tag1"
+            ],
+            "target": {
+                "database": "bigquery-public-data",
+                "name": "taxi_trips",
+                "schema": "chicago_taxi_trips"
+            },
+            "type": "table"
+        },
+        {
+            "canonicalTarget": {
+                "database": "bigquery-public-data",
+                "name": "crime",
+                "schema": "chicago_crime"
+            },
+            "dependencyTargets": [],
+            "disabled": false,
+            "enumType": "TABLE",
+            "fileName": "",
+            "query": "\n\n SELECT 1 \n",
+            "tags": [
+                "tag2"
+            ],
+            "target": {
+                "database": "bigquery-public-data",
+                "name": "crime",
+                "schema": "chicago_crime"
+            },
+            "type": "table"
+        }
+    ],
+    "targets": []
 }

Original file line number	Diff line number	Diff line change
`@@ -171,3 +171,4 @@ result.json`
`171`	`171`	`.vscode/`
`172`	`172`
`173`	`173`	`.DS_Store`
	`174`	`+.envrc`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-"""Test configuraitons."""`
	`1`	`+"""Test configurations."""`
`2`	`2`
`3`	`3`	`from pytest import FixtureRequest, Parser, fixture`
`4`	`4`