Skip to content

Commit d0f1f44

Browse files
committed
properly persist config version to disk (fixes #19)
1 parent eb8c059 commit d0f1f44

3 files changed

Lines changed: 8 additions & 2 deletions

File tree

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
## 0.6.0
22
**:boom: Breaking Changes**
33
- Made `System.ShouldLoad` abstract ([#6](https://git.omni.ms/vintage-story-mods/common-mod/issues/6))
4+
- Changed `IRootConfig.Version` from a method to a property ([#19](https://git.omni.ms/vintage-story-mods/common-mod/issues/19))
45

56
**:sparkles: Features**
67
- Added `System.RegisterClasses` virtual method ([#5](https://git.omni.ms/vintage-story-mods/common-mod/issues/5))
@@ -22,6 +23,9 @@
2223
- Added `IWorldAccessor.WalkBlocksCylinder` extension method ([#9](https://git.omni.ms/vintage-story-mods/common-mod/issues/9))
2324
- Added `IWorldAccessor.WalkBlocksSphere` extension method ([#9](https://git.omni.ms/vintage-story-mods/common-mod/issues/9))
2425

26+
**:bug: Bug Fixes**
27+
- Correctly persist configuration version to disk ([#19](https://git.omni.ms/vintage-story-mods/common-mod/issues/19))
28+
2529
**:hammer: Refactors**
2630
- Cleanup pass ([#1](https://git.omni.ms/vintage-story-mods/common-mod/issues/1))
2731

Common.Mod.Common/Config/IRootConfig.cs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ namespace Common.Mod.Common.Config;
22

33
public interface IRootConfig : IConfig
44
{
5-
public string Version();
5+
public string Version { get; }
6+
67
public RootConfigType Type();
78
}

Common.Mod.Generator/Generators/ConfigGenerator.cs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,8 @@ private static string GenerateConfig(RootConfigSpec spec)
7878
sourceBuilder.AppendLine();
7979
sourceBuilder.AppendLine("#region IRootConfig");
8080
sourceBuilder.AppendLine();
81-
sourceBuilder.AppendLine($"public string Version() => \"{spec.Version}\";");
81+
sourceBuilder.AppendLine($"public string Version {{ get; }} = \"{spec.Version}\";");
82+
sourceBuilder.AppendLine();
8283
sourceBuilder.AppendLine($"public RootConfigType Type() => RootConfigType.{spec.Type};");
8384
sourceBuilder.AppendLine();
8485
sourceBuilder.AppendLine("#endregion IRootConfig");

0 commit comments

Comments
 (0)