fix ctd due to improper event handler registration (fixes #9)

Author: devpikachu

CHANGELOG.md

@@ -1,3 +1,8 @@
+## 21.1.3
+**:bug: Bug Fixes**
+- Fix CTD due to improper registering of `OnAssetsLoaded` event handler
+- Fix CTD due to null `Readings` array access in `ReadingPacket`
+
 ## 21.1.2
 **:bug: Bug Fixes**
 - Fix CTD due to accessing assets before `ASSETS_LOADED`

DurableBetterProspecting/DurableBetterProspectingSystem.cs

@@ -31,6 +31,13 @@ public override void StartPre(ICoreAPI api)
             var legacyConfigManager = Container.Resolve<LegacyConfigManager>();
             legacyConfigManager.Migrate();
         }
+
+        // Make sure that managers are instantiated
+        {
+            // ReSharper disable UnusedVariable
+            var modeManager = Container.Resolve<ModeManager>();
+            // ReSharper restore UnusedVariable
+        }
     }
 
     public override void Start(ICoreAPI api)

DurableBetterProspecting/Managers/ReadingManager.cs

@@ -61,7 +61,9 @@ IConfigSystem configSystem
 
     private void ProcessReading(ReadingPacket packet)
     {
-        _logger.Verbose("Received packet with {0} readings", packet.Readings.Length);
+        var readingsArray = packet.Readings ?? [];
+
+        _logger.Verbose("Received packet with {0} readings", readingsArray.Length);
         var stopwatch = Stopwatch.StartNew();
 
         var messageBuilder = new StringBuilder();
@@ -87,7 +89,7 @@ private void ProcessReading(ReadingPacket packet)
 
         // Message: No rocks/ores found
         {
-            if (packet.Readings.Length == 0)
+            if (readingsArray.Length == 0)
             {
                 var sampleEmptyString = _translations.Get("reading--sample-empty", packet.Mode is Constants.RockModeId ? rocksString : oresString);
 
@@ -102,7 +104,7 @@ private void ProcessReading(ReadingPacket packet)
         }
 
         // Sort readings
-        var readings = packet.Readings.AsEnumerable();
+        var readings = readingsArray.AsEnumerable();
         if (_clientConfig.Ordering.Enabled)
         {
             var ascending = _clientConfig.Ordering.Direction is OrderingDirection.Ascending;

DurableBetterProspecting/Network/ReadingPacket.cs

@@ -17,5 +17,5 @@ internal record ReadingPacket
     public required Vec3i? Position { get; init; }
 
     [ProtoMember(4)]
-    public required Reading[] Readings { get; init; }
+    public required Reading[]? Readings { get; init; }
 }