fix(cmake): use correct GLFW and OpenGL target names for all platforms

LyeZinho · LyeZinho · commit cb5925cc3cff · 2026-04-09T15:51:00.000+01:00
- GLFW::GLFW → glfw  (vcpkg glfw3 and source installs both create 'glfw')
- OpenGL::OpenGL → OpenGL::GL  (OpenGL::OpenGL is GLVND-only; OpenGL::GL
  is the cross-platform target that exists on Windows and Linux)
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -35,8 +35,8 @@ if(GLFW3_FOUND AND OpenGL_FOUND AND GLAD_FOUND AND ImGui_FOUND)
     src/core/gfx/render_texture.cpp
   )
   target_link_libraries(convoy_core PUBLIC
-    GLFW::GLFW
-    OpenGL::OpenGL
+    glfw
+    OpenGL::GL
     GLAD::GLAD
     ImGui::ImGui
   )
diff --git a/src/cmake/FindImGui.cmake b/src/cmake/FindImGui.cmake
@@ -21,7 +21,7 @@ if(EXISTS "${IMGUI_DIR}/imgui.h" AND
       "${IMGUI_DIR}/backends/imgui_impl_opengl3.cpp"
       "${IMGUI_DIR}/backends/imgui_impl_glfw.cpp"
     )
-    target_link_libraries(ImGui INTERFACE OpenGL::OpenGL GLFW::GLFW)
+    target_link_libraries(ImGui INTERFACE OpenGL::GL glfw)
     add_library(ImGui::ImGui ALIAS ImGui)
   endif()
   set(ImGui_FOUND TRUE)

Original file line number	Diff line number	Diff line change
`@@ -35,8 +35,8 @@ if(GLFW3_FOUND AND OpenGL_FOUND AND GLAD_FOUND AND ImGui_FOUND)`
`35`	`35`	`src/core/gfx/render_texture.cpp`
`36`	`36`	`)`
`37`	`37`	`target_link_libraries(convoy_core PUBLIC`
`38`		`- GLFW::GLFW`
`39`		`- OpenGL::OpenGL`
	`38`	`+ glfw`
	`39`	`+ OpenGL::GL`
`40`	`40`	`GLAD::GLAD`
`41`	`41`	`ImGui::ImGui`
`42`	`42`	`)`
Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,7 @@ if(EXISTS "${IMGUI_DIR}/imgui.h" AND`
`21`	`21`	`"${IMGUI_DIR}/backends/imgui_impl_opengl3.cpp"`
`22`	`22`	`"${IMGUI_DIR}/backends/imgui_impl_glfw.cpp"`
`23`	`23`	`)`
`24`		`- target_link_libraries(ImGui INTERFACE OpenGL::OpenGL GLFW::GLFW)`
	`24`	`+ target_link_libraries(ImGui INTERFACE OpenGL::GL glfw)`
`25`	`25`	`add_library(ImGui::ImGui ALIAS ImGui)`
`26`	`26`	`endif()`
`27`	`27`	`set(ImGui_FOUND TRUE)`