Skip to content

Commit a0ff75b

Browse files
committed
Fix test config for SQL Server
1 parent 850c6a8 commit a0ff75b

2 files changed

Lines changed: 15 additions & 6 deletions

File tree

test/MssqlDbTest.php

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -29,10 +29,10 @@ public static function dbProvider(): PeachySql
2929
{
3030
if (!self::$db) {
3131
$c = App::$config;
32-
$server = $c->getSqlsrvServer();
32+
$server = $c->getMssqlServer();
3333
$connStr = getenv('MSSQL_CONNECTION_STRING');
34-
$username = '';
35-
$password = '';
34+
$username = $c->getMssqlUsername();
35+
$password = $c->getMssqlPassword();
3636

3737
if ($connStr !== false) {
3838
// running tests with GitHub Actions
@@ -49,10 +49,9 @@ public static function dbProvider(): PeachySql
4949
}
5050
}
5151

52-
$pdo = new PDO("sqlsrv:server=$server", $username, $password, [
52+
$pdo = new PDO("sqlsrv:Server=$server;Database=PeachySQL", $username, $password, [
5353
PDO::ATTR_EMULATE_PREPARES => false,
5454
PDO::SQLSRV_ATTR_FETCHES_NUMERIC_TYPE => true,
55-
'Database' => 'PeachySQL',
5655
]);
5756

5857
self::$db = new PeachySql($pdo);

test/src/Config.php

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,8 +37,18 @@ public function getPgsqlPassword(): string
3737
return 'postgres';
3838
}
3939

40-
public function getSqlsrvServer(): string
40+
public function getMssqlServer(): string
4141
{
4242
return '(local)\SQLEXPRESS';
4343
}
44+
45+
public function getMssqlUsername(): string
46+
{
47+
return '';
48+
}
49+
50+
public function getMssqlPassword(): string
51+
{
52+
return '';
53+
}
4454
}

0 commit comments

Comments
 (0)