Optimize Handlebars::escapeExpression()

theodorejb · theodorejb · commit 6d969978fc3a · 2026-03-29T20:01:21.000-05:00
diff --git a/src/Handlebars.php b/src/Handlebars.php
@@ -52,8 +52,14 @@ public static function template(string $templateSpec): \Closure
      */
     public static function escapeExpression(string $string): string
     {
-        $search = ['&', '<', '>', '"', "'", '`', '='];
-        $replace = ['&amp;', '&lt;', '&gt;', '&quot;', '&#x27;', '&#x60;', '&#x3D;'];
-        return str_replace($search, $replace, $string);
+        return strtr($string, [
+            '&' => '&amp;',
+            '<' => '&lt;',
+            '>' => '&gt;',
+            '"' => '&quot;',
+            "'" => '&#x27;',
+            '`' => '&#x60;',
+            '=' => '&#x3D;',
+        ]);
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -52,8 +52,14 @@ public static function template(string $templateSpec): \Closure`
`52`	`52`	`*/`
`53`	`53`	`public static function escapeExpression(string $string): string`
`54`	`54`	`{`
`55`		- $search = ['&', '<', '>', '"', "'", '`', '='];
`56`		`- $replace = ['&', '<', '>', '"', ''', '`', '='];`
`57`		`- return str_replace($search, $replace, $string);`
	`55`	`+ return strtr($string, [`
	`56`	`+ '&' => '&',`
	`57`	`+ '<' => '<',`
	`58`	`+ '>' => '>',`
	`59`	`+ '"' => '"',`
	`60`	`+ "'" => ''',`
	`61`	+ '`' => '`',
	`62`	`+ '=' => '=',`
	`63`	`+ ]);`
`58`	`64`	`}`
`59`	`65`	`}`