Avoid unnecessary count() calls at runtime

Author: theodorejb

src/Compiler.php

@@ -933,12 +933,13 @@ private function buildInlineHelperCall(string $name, array $params, ?Hash $hash)
     {
         $compiledParams = $this->compileParams($params, $hash);
         $helperName = self::quote($name);
+        $count = count($params);
         if ($this->isKnownHelper($name)) {
-            return self::getRuntimeFunc('hbch', "\$cx, \$cx->helpers[$helperName], $helperName, $compiledParams, \$in");
+            return self::getRuntimeFunc('hbch', "\$cx, \$cx->helpers[$helperName], $helperName, $count, $compiledParams, \$in");
         }
         if ($this->context->options->knownHelpersOnly) {
             $this->throwKnownHelpersOnly($name);
         }
-        return self::getRuntimeFunc('dynhbch', "\$cx, $helperName, $compiledParams, \$in");
+        return self::getRuntimeFunc('dynhbch', "\$cx, $helperName, $count, $compiledParams, \$in");
     }
 }

src/Runtime.php

@@ -230,12 +230,12 @@ public static function hv(RuntimeContext $cx, string $name, mixed &$_this): mixe
     {
         $helper = $cx->helpers[$name] ?? null;
         if ($helper !== null) {
-            return static::hbch($cx, $helper, $name, [], [], $_this);
+            return static::hbch($cx, $helper, $name, 0, [], [], $_this);
         }
         if (is_array($_this) && array_key_exists($name, $_this)) {
             return static::dv($_this[$name]);
         }
-        return static::hbch($cx, $cx->helpers['helperMissing'], $name, [], [], $_this);
+        return static::hbch($cx, $cx->helpers['helperMissing'], $name, 0, [], [], $_this);
     }
 
     /**
@@ -427,24 +427,24 @@ public static function in(RuntimeContext $cx, string $name, \Closure $partial):
      * @param array<mixed> $positional
      * @param array<string, mixed> $hash
      */
-    public static function dynhbch(RuntimeContext $cx, string $name, array $positional, array $hash, mixed &$_this): mixed
+    public static function dynhbch(RuntimeContext $cx, string $name, int $positionalCount, array $positional, array $hash, mixed &$_this): mixed
     {
         $helper = $cx->helpers[$name] ?? null;
         if ($helper !== null) {
-            return static::hbch($cx, $helper, $name, $positional, $hash, $_this);
+            return static::hbch($cx, $helper, $name, $positionalCount, $positional, $hash, $_this);
         }
 
         $fn = $_this[$name] ?? null;
         if ($fn instanceof \Closure) {
-            return static::hbch($cx, $fn, $name, $positional, $hash, $_this);
+            return static::hbch($cx, $fn, $name, $positionalCount, $positional, $hash, $_this);
         }
 
         if (!$positional && !$hash) {
             // No arguments: must be a helper call (e.g. sub-expression), not a property lookup.
             throw new \Exception('Missing helper: "' . $name . '"');
         }
 
-        return static::hbch($cx, $cx->helpers['helperMissing'], $name, $positional, $hash, $_this);
+        return static::hbch($cx, $cx->helpers['helperMissing'], $name, $positionalCount, $positional, $hash, $_this);
     }
 
     /**
@@ -454,7 +454,7 @@ public static function dynhbch(RuntimeContext $cx, string $name, array $position
      * @param array<string, mixed> $hash
      * @param mixed $_this current rendering context for the helper
      */
-    public static function hbch(RuntimeContext $cx, \Closure $helper, string $name, array $positional, array $hash, mixed &$_this): mixed
+    public static function hbch(RuntimeContext $cx, \Closure $helper, string $name, int $positionalCount, array $positional, array $hash, mixed &$_this): mixed
     {
         /** @var \WeakMap<\Closure, int>|null $paramCounts */
         static $paramCounts = null;
@@ -469,7 +469,7 @@ public static function hbch(RuntimeContext $cx, \Closure $helper, string $name,
             $numParams = $params && end($params)->isVariadic() ? 0 : $rf->getNumberOfParameters();
             $paramCounts[$helper] = $numParams;
         }
-        if ($numParams === 0 || $numParams > count($positional)) {
+        if ($numParams === 0 || $numParams > $positionalCount) {
             $positional[] = new HelperOptions(
                 scope: $_this,
                 data: $cx->frame,