Skip to content

Commit b78dc62

Browse files
committed
feat: explicitly support getNodeByNodeId
also remove readonly
1 parent 9c5649c commit b78dc62

2 files changed

Lines changed: 4 additions & 3 deletions

File tree

src/Inspector.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -507,8 +507,9 @@ export class Inspector extends EventEmitter {
507507
this.buildNodeTree(root);
508508
}
509509

510-
// for checking node tracked only
511-
_getNodeByNodeId(nodeId: number): Readonly<InspectorNode> | undefined {
510+
// mainly for checking node tracked
511+
// also useful for mapping manually requested NodeId to InspectorNode
512+
getNodeByNodeId(nodeId: number): InspectorNode | undefined {
512513
const node = this.idToNode.get(nodeId);
513514
return node;
514515
}

src/InspectorDOM.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ export class InspectorNode {
3636

3737
get tracked(): boolean {
3838
// check if the node is still tracked by inspector
39-
const node = this.inspector._getNodeByNodeId(this._cdpNode.nodeId);
39+
const node = this.inspector.getNodeByNodeId(this._cdpNode.nodeId);
4040
return node === this;
4141
}
4242

0 commit comments

Comments
 (0)