Add unit tests for missing coverage

Author: rlskoeser

src/undate/undate.py

@@ -35,10 +35,15 @@ class Calendar(StrEnum):
     def get_converter(calendar) -> BaseCalendarConverter:
         # calendar converter must be available with a name matching
         # the title-case name of the calendar enum entry
-        converter_cls = BaseDateConverter.available_converters()[calendar.value.title()]
+        try:
+            converter_cls = BaseDateConverter.available_converters()[
+                calendar.value.title()
+            ]
+        except KeyError:
+            raise ValueError(f"Unknown calendar '{calendar}'")
         if not issubclass(converter_cls, BaseCalendarConverter):
             raise ValueError(
-                f"Requested converter {converter_cls} is not a CalendarConverter"
+                f"Requested converter '{calendar.value.title()}' is not a CalendarConverter"
             )
         return converter_cls()
 

tests/test_converters/test_calendars/test_hebrew/test_hebrew_converter.py

@@ -154,6 +154,13 @@ def test_compare_across_calendars(self):
         expected_gregorian_years = [-3261, 33, 1056, 1350, 1655, 1995]
         assert [d.earliest.year for d in sorted_dates] == expected_gregorian_years
 
+    def test_days_in_year(self):
+        converter = HebrewDateConverter()
+        assert converter.days_in_year(4816) == 353
+        assert converter.days_in_year(4817) == 355
+        assert converter.days_in_year(4818) == 384
+        assert converter.days_in_year(4819) == 355
+
     def test_representative_years(self):
         converter = HebrewDateConverter()
         # single year is not filtered

tests/test_converters/test_calendars/test_seleucid.py

@@ -53,6 +53,12 @@ def test_gregorian_earliest_latest(self):
         assert date.latest == Date(1146, 10, 15)
         assert date.label == f"{date_str} {SeleucidDateConverter.calendar_name}"
 
+    def test_days_in_year(self):
+        converter = SeleucidDateConverter()
+        assert converter.days_in_year(2350) == 354
+        assert converter.days_in_year(2349) == 385
+        assert converter.days_in_year(2351) == 355
+
 
 # TODO: update validation error to say seleucid instead of hebrew
 

tests/test_undate.py

@@ -1,9 +1,11 @@
 from datetime import date, datetime
+from enum import auto
 
 import pytest
 
 from undate import Undate, UndateInterval, Calendar
-from undate.converters.base import BaseCalendarConverter
+from undate.undate import StrEnum  # import whichever version is used there
+from undate.converters.base import BaseCalendarConverter, BaseDateConverter
 from undate.date import Date, DatePrecision, Timedelta, UnDelta, UnInt
 
 
@@ -545,3 +547,25 @@ def test_calendar_get_converter():
         converter = Calendar.get_converter(cal)
         assert isinstance(converter, BaseCalendarConverter)
         assert converter.name.lower() == cal.name.lower()
+
+    class BogusCalendar(StrEnum):
+        """Unsupported calendars"""
+
+        FOOBAR = auto()
+        DUMMY = auto()
+
+    # test error handling
+    # ensure we raise a ValueError when an invalid calendar is requested
+    with pytest.raises(ValueError, match="Unknown calendar"):
+        Calendar.get_converter(BogusCalendar.FOOBAR)
+
+    class DummyFormatter(BaseDateConverter):
+        name = "Dummy"
+
+    # also error if you request a converter that is not a calendar converter
+    # NOTE: this fails because get_converter converts the enum to title case...
+    # can't be tested with any of the existing non-calendar converters
+    with pytest.raises(
+        ValueError, match="Requested converter 'Dummy' is not a CalendarConverter"
+    ):
+        Calendar.get_converter(BogusCalendar.DUMMY)