fix: avoid double fetch of the same page

The all items selected was rendering wrongly triggering a 2nd fetch of the
same page of items which was causing duplicated items in the
Transfer's source list.

Author: edoardo

i18n/en.pot

@@ -5,8 +5,8 @@ msgstr ""
 "Content-Type: text/plain; charset=utf-8\n"
 "Content-Transfer-Encoding: 8bit\n"
 "Plural-Forms: nplurals=2; plural=(n != 1)\n"
-"POT-Creation-Date: 2025-02-24T10:59:13.262Z\n"
-"PO-Revision-Date: 2025-02-24T10:59:13.263Z\n"
+"POT-Creation-Date: 2025-02-27T14:06:17.569Z\n"
+"PO-Revision-Date: 2025-02-27T14:06:17.570Z\n"
 
 msgid "view only"
 msgstr "view only"
@@ -336,6 +336,9 @@ msgstr "Search by data item name"
 msgid "Selected Items"
 msgstr "Selected Items"
 
+msgid "All available items are already selected"
+msgstr "All available items are already selected"
+
 msgid "Calculation"
 msgstr "Calculation"
 
@@ -348,9 +351,6 @@ msgstr "All metrics"
 msgid "No items selected"
 msgstr "No items selected"
 
-msgid "All available items are already selected"
-msgstr "All available items are already selected"
-
 msgid "No indicators found"
 msgstr "No indicators found"
 

src/components/DataDimension/ItemOptionsSelector/ItemOptionsSelector.js

@@ -168,17 +168,31 @@ export const ItemOptionsSelector = ({
             <Transfer
                 onChange={({ selected }) => onChange(selected)}
                 selected={selectedItems.map((item) => item.value)}
-                options={[...state.options, ...selectedItems]}
+                options={[
+                    ...state.options,
+                    // remove items already in the options list
+                    ...selectedItems.filter(
+                        (selectedItem) =>
+                            !state.options?.find(
+                                (option) => option.value === selectedItem.value
+                            )
+                    ),
+                ]}
                 loading={state.loading}
                 loadingPicked={state.loading}
                 sourceEmptyPlaceholder={
                     <SourceEmptyPlaceholder
                         loading={state.loading}
                         searchTerm={debouncedSearchTerm}
                         options={state.options}
-                        allItemsSelectedMessage={i18n.t(
-                            'All available options are already selected'
-                        )}
+                        allItemsSelectedMessage={
+                            state.options.length === selectedItems.length &&
+                            !state.nextPage
+                                ? i18n.t(
+                                      'All available options are already selected'
+                                  )
+                                : ''
+                        }
                         noItemsMessage={i18n.t(
                             'No available options for this item'
                         )}

src/components/DataDimension/ItemSelector/ItemSelector.js

@@ -350,14 +350,31 @@ const ItemSelector = ({
             <Transfer
                 onChange={({ selected }) => onChange(selected)}
                 selected={selectedItems.map((item) => item.value)}
-                options={[...state.options, ...selectedItems]}
+                options={[
+                    ...state.options,
+                    // remove items already in the options list
+                    ...selectedItems.filter(
+                        (selectedItem) =>
+                            !state.options?.find(
+                                (option) => option.value === selectedItem.value
+                            )
+                    ),
+                ]}
                 loading={state.loading}
                 loadingPicked={state.loading}
                 sourceEmptyPlaceholder={
                     <SourceEmptyPlaceholder
                         loading={state.loading}
                         searchTerm={debouncedSearchTerm}
                         options={state.options}
+                        allItemsSelectedMessage={
+                            state.options.length === selectedItems.length &&
+                            !state.nextPage
+                                ? i18n.t(
+                                      'All available items are already selected'
+                                  )
+                                : ''
+                        }
                         noItemsMessage={noItemsMessage}
                         dataType={state.filter.dataType}
                         dataTest={`${dataTest}-empty-source`}

src/components/DataDimension/SourceEmptyPlaceholder.js

@@ -21,10 +21,8 @@ export const SourceEmptyPlaceholder = ({
     dataTest,
 }) => {
     let message = ''
-    if (!loading && options.length && !searchTerm) {
-        message =
-            allItemsSelectedMessage ||
-            i18n.t('All available items are already selected')
+    if (allItemsSelectedMessage && !loading && options.length && !searchTerm) {
+        message = allItemsSelectedMessage
     } else if (!loading && !options.length && !searchTerm) {
         if (noItemsMessage) {
             message = noItemsMessage