Skip to content

Commit b5664bf

Browse files
committed
feat: add height property to DataDimension
1 parent d65967d commit b5664bf

3 files changed

Lines changed: 10 additions & 2 deletions

File tree

src/components/DataDimension/DataDimension.js

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@ const DataDimension = ({
3131
infoBoxMessage,
3232
onCalculationSave,
3333
visType,
34+
height,
3435
}) => {
3536
const { serverVersion } = useConfig()
3637

@@ -130,6 +131,7 @@ const DataDimension = ({
130131
infoDataItem={infoDataItem}
131132
setInfoDataItem={setInfoDataItem}
132133
onEditClick={onEditClick}
134+
height={height}
133135
/>
134136
{currentDataItem && (
135137
<ItemOptionsSelector
@@ -143,6 +145,7 @@ const DataDimension = ({
143145
setInfoDataItem={setInfoDataItem}
144146
onClose={() => setCurrentDataItem()}
145147
onEditClick={onEditClick}
148+
height={height}
146149
/>
147150
)}
148151
{infoDataItem && (
@@ -172,6 +175,7 @@ DataDimension.propTypes = {
172175
onSelect: PropTypes.func.isRequired,
173176
currentUser: PropTypes.object,
174177
enabledDataTypes: PropTypes.array,
178+
height: PropTypes.string,
175179
infoBoxMessage: PropTypes.string,
176180
visType: PropTypes.string,
177181
onCalculationSave: PropTypes.func,

src/components/DataDimension/ItemOptionsSelector/ItemOptionsSelector.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,7 @@ export const ItemOptionsSelector = ({
5454
onSelect,
5555
onClose,
5656
dataTest,
57+
height = TRANSFER_HEIGHT,
5758
}) => {
5859
const [state, setState] = useState({
5960
searchTerm: '',
@@ -236,7 +237,7 @@ export const ItemOptionsSelector = ({
236237
<p className="rightHeader">{i18n.t('Selected items')}</p>
237238
}
238239
enableOrderChange
239-
height={TRANSFER_HEIGHT}
240+
height={height}
240241
optionsWidth={TRANSFER_OPTIONS_WIDTH}
241242
selectedWidth={TRANSFER_SELECTED_WIDTH}
242243
selectedEmptyComponent={<SelectedEmptyPlaceholder />}
@@ -282,6 +283,7 @@ ItemOptionsSelector.propTypes = {
282283
onClose: PropTypes.func.isRequired,
283284
onSelect: PropTypes.func.isRequired,
284285
dataTest: PropTypes.string,
286+
height: PropTypes.string,
285287
infoDataItem: PropTypes.object,
286288
itemsRef: PropTypes.object,
287289
selectedItems: PropTypes.arrayOf(

src/components/DataDimension/ItemSelector/ItemSelector.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -136,6 +136,7 @@ const ItemSelector = ({
136136
onEditClick,
137137
isOptionViewMode,
138138
supportsEDI,
139+
height = TRANSFER_HEIGHT,
139140
}) => {
140141
const [state, setState] = useState({
141142
searchTerm: '',
@@ -412,7 +413,7 @@ const ItemSelector = ({
412413
) : undefined
413414
}
414415
enableOrderChange
415-
height={TRANSFER_HEIGHT}
416+
height={height}
416417
optionsWidth={TRANSFER_OPTIONS_WIDTH}
417418
selectedWidth={TRANSFER_SELECTED_WIDTH}
418419
selectedEmptyComponent={<SelectedEmptyPlaceholder />}
@@ -464,6 +465,7 @@ ItemSelector.propTypes = {
464465
currentCalculation: PropTypes.object,
465466
dataTest: PropTypes.string,
466467
dataTypes: PropTypes.array,
468+
height: PropTypes.string,
467469
infoBoxMessage: PropTypes.string,
468470
infoDataItem: PropTypes.object,
469471
isOptionViewMode: PropTypes.bool,

0 commit comments

Comments
 (0)