fix(types): improve types for useDataQuery.ts

Author: Birkbjo

services/data/src/engine/types/Query.ts

@@ -18,9 +18,19 @@ export interface ResolvedResourceQuery extends ResourceQuery {
     params?: QueryParameters
 }
 
-export type Query = Record<string, ResourceQuery>
+export type Query<TQueryResult extends QueryResult = QueryResult> = Record<
+    keyof TQueryResult,
+    ResourceQuery
+>
 export type QueryResult = JsonMap
 
+export type QueryResultData<
+    TQuery extends Query<TQueryResultData>,
+    TQueryResultData extends QueryResult = QueryResult
+> = {
+    [K in keyof TQuery]: TQueryResultData
+}
+
 export interface QueryOptions {
     variables?: QueryVariables
     onComplete?: (data: QueryResult) => void

services/data/src/react/hooks/useDataQuery.ts

@@ -3,11 +3,11 @@ import { useQuery, setLogger } from 'react-query'
 import type {
     Query,
     QueryOptions,
-    QueryResult,
     QueryVariables,
+    QueryResultData
 } from '../../engine'
 import type { FetchError } from '../../engine/types/FetchError'
-import type { QueryRenderInput, QueryRefetchFunction } from '../../types'
+import type { DataQueryResult, QueryRefetchFunction } from '../../types'
 import { mergeAndCompareVariables } from './mergeAndCompareVariables'
 import { useDataEngine } from './useDataEngine'
 import { useStaticInput } from './useStaticInput'
@@ -33,15 +33,18 @@ type QueryState = {
     refetchCallback?: (data: any) => void
 }
 
-export const useDataQuery = <TQueryResult = QueryResult>(
-    query: Query,
+export const useDataQuery = <
+    TQueryResultData extends QueryResultData<TQuery>,
+    TQuery extends Query<TQueryResultData> = Query<TQueryResultData>
+>(
+    query: TQuery,
     {
         onComplete: userOnSuccess,
         onError: userOnError,
         variables: initialVariables = {},
         lazy: initialLazy = false,
     }: QueryOptions = {}
-): QueryRenderInput<TQueryResult> => {
+): DataQueryResult<TQueryResultData> => {
     const [staticQuery] = useStaticInput<Query>(query, {
         warn: true,
         name: 'query',

services/data/src/types.ts

@@ -54,6 +54,8 @@ export interface QueryRenderInput<TQueryResult = QueryResult>
     refetch: QueryRefetchFunction
 }
 
+export type DataQueryResult<TQueryResult> = QueryRenderInput<TQueryResult>
+
 export interface MutationState {
     engine: DataEngine
     called: boolean