feat: add EmergencyCallingServiceStatus enum and use it for status field

Replace raw string constants with a proper EmergencyCallingServiceStatus
enum (active, canceled, changes_required, in_process, new, pending_update),
matching the pattern used by VoiceOutTrunkStatus and ExportStatus. Update
predicates to compare against enum members.

Author: Fivell

src/didww/enums.py

@@ -81,6 +81,15 @@ class DefaultDstAction(str, Enum):
     REJECT_ALL = "reject_all"
 
 
+class EmergencyCallingServiceStatus(str, Enum):
+    ACTIVE = "active"
+    CANCELED = "canceled"
+    CHANGES_REQUIRED = "changes required"
+    IN_PROCESS = "in process"
+    NEW = "new"
+    PENDING_UPDATE = "pending update"
+
+
 class VoiceOutTrunkStatus(str, Enum):
     ACTIVE = "active"
     BLOCKED = "blocked"

src/didww/resources/emergency_calling_service.py

@@ -1,4 +1,5 @@
-from didww.resources.base import DidwwApiModel, DatetimeAttributeField, SafeAttributeField, RelationField, ReadOnlyRepository
+from didww.enums import EmergencyCallingServiceStatus
+from didww.resources.base import DidwwApiModel, DatetimeAttributeField, SafeAttributeField, EnumAttributeField, RelationField, ReadOnlyRepository
 
 
 class EmergencyCallingService(DidwwApiModel):
@@ -7,8 +8,8 @@ class EmergencyCallingService(DidwwApiModel):
     Attributes:
         name (str): Human-readable name for the calling service subscription.
         reference (str): Server-assigned reference code.
-        status (str): One of "active", "canceled", "changes required",
-            "in process", "new", "pending update".
+        status (EmergencyCallingServiceStatus): One of active, canceled,
+            changes_required, in_process, new, pending_update.
         activated_at (datetime): Timestamp when the service became active. None while pending.
         canceled_at (datetime): Timestamp when the service was canceled. None when active.
         created_at (datetime): Timestamp when the resource was created.
@@ -17,7 +18,7 @@ class EmergencyCallingService(DidwwApiModel):
 
     name = SafeAttributeField("name")
     reference = SafeAttributeField("reference")
-    status = SafeAttributeField("status")
+    status = EnumAttributeField("status", EmergencyCallingServiceStatus)
     activated_at = DatetimeAttributeField("activated_at")
     canceled_at = DatetimeAttributeField("canceled_at")
     created_at = DatetimeAttributeField("created_at")
@@ -31,39 +32,32 @@ class EmergencyCallingService(DidwwApiModel):
     emergency_verification = RelationField("emergency_verification")
     dids = RelationField("dids")
 
-    STATUS_ACTIVE = "active"
-    STATUS_CANCELED = "canceled"
-    STATUS_CHANGES_REQUIRED = "changes required"
-    STATUS_IN_PROCESS = "in process"
-    STATUS_NEW = "new"
-    STATUS_PENDING_UPDATE = "pending update"
-
     class Meta:
         type = "emergency_calling_services"
 
     @property
     def is_active(self):
-        return self.status == self.STATUS_ACTIVE
+        return self.status == EmergencyCallingServiceStatus.ACTIVE
 
     @property
     def is_canceled(self):
-        return self.status == self.STATUS_CANCELED
+        return self.status == EmergencyCallingServiceStatus.CANCELED
 
     @property
     def is_changes_required(self):
-        return self.status == self.STATUS_CHANGES_REQUIRED
+        return self.status == EmergencyCallingServiceStatus.CHANGES_REQUIRED
 
     @property
     def is_in_process(self):
-        return self.status == self.STATUS_IN_PROCESS
+        return self.status == EmergencyCallingServiceStatus.IN_PROCESS
 
     @property
     def is_new(self):
-        return self.status == self.STATUS_NEW
+        return self.status == EmergencyCallingServiceStatus.NEW
 
     @property
     def is_pending_update(self):
-        return self.status == self.STATUS_PENDING_UPDATE
+        return self.status == EmergencyCallingServiceStatus.PENDING_UPDATE
 
 
 class EmergencyCallingServiceRepository(ReadOnlyRepository):

tests/resources/test_emergency_calling_service.py

@@ -1,29 +1,35 @@
 from datetime import datetime, timezone
 
 from tests.conftest import my_vcr
+from didww.enums import EmergencyCallingServiceStatus
 from didww.resources.emergency_calling_service import EmergencyCallingService
 
 
 class TestEmergencyCallingServiceStatusHelpers:
     def test_is_active(self):
         ecs = EmergencyCallingService()
-        ecs.status = "active"
+        ecs.status = EmergencyCallingServiceStatus.ACTIVE
         assert ecs.is_active is True
         assert ecs.is_canceled is False
 
     def test_all_predicates(self):
         ecs = EmergencyCallingService()
-        ecs.status = "canceled"
+        ecs.status = EmergencyCallingServiceStatus.CANCELED
         assert ecs.is_canceled is True
-        ecs.status = "changes required"
+        ecs.status = EmergencyCallingServiceStatus.CHANGES_REQUIRED
         assert ecs.is_changes_required is True
-        ecs.status = "in process"
+        ecs.status = EmergencyCallingServiceStatus.IN_PROCESS
         assert ecs.is_in_process is True
-        ecs.status = "new"
+        ecs.status = EmergencyCallingServiceStatus.NEW
         assert ecs.is_new is True
-        ecs.status = "pending update"
+        ecs.status = EmergencyCallingServiceStatus.PENDING_UPDATE
         assert ecs.is_pending_update is True
 
+    def test_status_enum_from_string(self):
+        ecs = EmergencyCallingService()
+        ecs.status = "active"
+        assert ecs.status == EmergencyCallingServiceStatus.ACTIVE
+
 
 class TestEmergencyCallingService:
     @my_vcr.use_cassette("emergency_calling_services/list.yaml")