Skip to content

Commit 69692ad

Browse files
Merge pull request #86 from dragonyanglong/fix_py3_thread
Fix py3 thread
2 parents c84b072 + 40cc24e commit 69692ad

4 files changed

Lines changed: 7 additions & 4 deletions

File tree

CHANGELOG.md

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,10 +11,13 @@ Notable differences from version 1.1.2.
1111

1212
### Changed
1313

14+
- Update wxpython to 4.1.1, and remove incompatible align flags.
15+
1416
### Deprecated
1517

1618
### Removed
1719

1820
### Fixed
1921

20-
- Incompatible conversion between bytes and str from py2 to py3.
22+
- Incompatible conversion between bytes and str from py2 to py3.
23+
- Replace the deprecated `Thread.isAlive()` with `Thread.is_alive()`.

setup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515

1616
# Use this version when git data are not available, like in git zip archive.
1717
# Update when tagging a new release.
18-
FALLBACK_VERSION = '1.4.3'
18+
FALLBACK_VERSION = '1.4.6'
1919

2020
# determine if we run with Python 3.
2121
PY3 = (sys.version_info[0] == 3)

src/diffpy/pdfgui/control/fitting.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -553,7 +553,7 @@ def isThreadRunning(self):
553553
554554
return: True if running, False otherwise
555555
"""
556-
return self.thread is not None and self.thread.isAlive()
556+
return self.thread is not None and self.thread.is_alive()
557557

558558
def join(self):
559559
"""wait for current fitting to finish"""

src/diffpy/pdfgui/control/pdfguicontrol.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -159,7 +159,7 @@ def exit(self):
159159
"""exit when program finished
160160
"""
161161
self.close()
162-
if self.queueManager.isAlive():
162+
if self.queueManager.is_alive():
163163
self.queueManager.running = False
164164

165165
def newFitting(self, name, position=None):

0 commit comments

Comments
 (0)