Skip to content

Commit b6a629a

Browse files
committed
MAINT: replace deprecated unit test method
Replace `failUnless` --> `assertTrue`. Replace `failIf` --> `assertFalse`. No change in code function.
1 parent ad74bea commit b6a629a

7 files changed

Lines changed: 18 additions & 18 deletions

File tree

src/diffpy/pdfgui/tests/TestCalculation.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ def rgriddata(calc):
7373
# range should cover the argument range.
7474
self.calc.setRGrid(1, 0.7, 10)
7575
self.assertEqual(1, self.calc.rmin)
76-
self.failUnless(10 < self.calc.rmax)
76+
self.assertTrue(10 < self.calc.rmax)
7777
self.assertEqual(0.7, self.calc.rstep)
7878
return
7979

src/diffpy/pdfgui/tests/TestConstraint.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ def setUp(self):
3333
def test___init__(self):
3434
"""check Constraint.__init__()
3535
"""
36-
self.failUnless(1 in self.c.parguess)
36+
self.assertTrue(1 in self.c.parguess)
3737
self.assertEqual(1, len(self.c.parguess))
3838
c1 = Constraint('2*@2 + 3.0', 13.0)
3939
self.assertEqual(1, len(c1.parguess))

src/diffpy/pdfgui/tests/TestFitDataSet.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -200,7 +200,7 @@ def test__resampledPDFDataSet(self):
200200
# reduce fitrmax to one half
201201
fds.fitrmax = fds.rmax / 2.0
202202
npts1 = len(fds.rcalc)
203-
self.failUnless(npts1 < npts)
203+
self.assertTrue(npts1 < npts)
204204
rds1 = fds._resampledPDFDataSet()
205205
self.assertEqual(npts1, len(rds1.robs))
206206
self.assertEqual(npts1, len(rds1.drobs))

src/diffpy/pdfgui/tests/TestFitStructure.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ def test___getattr__(self):
5555
"""check FitStructure.__getattr__()
5656
"""
5757
stru = self.stru
58-
self.failUnless(stru is stru.initial)
58+
self.assertTrue(stru is stru.initial)
5959
self.assertRaises(AttributeError, eval,
6060
'stru.notdefined', locals())
6161
return
@@ -156,9 +156,9 @@ def test_insertAtoms(self):
156156
stru.insertAtoms(0, [Atom('Na', (0, 0, 0))])
157157
self.assertEqual(5, len(stru))
158158
self.assertEqual(1, len(stru.constraints))
159-
self.failUnless(cns is stru.constraints['x(3)'])
159+
self.assertTrue(cns is stru.constraints['x(3)'])
160160
stru.insertAtoms(5, [Atom('Cl', (0, 0, 0))])
161-
self.failUnless(['x(3)'] == stru.constraints.keys())
161+
self.assertTrue(['x(3)'] == stru.constraints.keys())
162162
return
163163

164164

@@ -171,10 +171,10 @@ def test_deleteAtoms(self):
171171
stru.constraints['x(2)'] = cns
172172
stru.deleteAtoms([3])
173173
self.assertEqual(['x(2)'], stru.constraints.keys())
174-
self.failUnless(cns is stru.constraints.values()[0])
174+
self.assertTrue(cns is stru.constraints.values()[0])
175175
stru.deleteAtoms([0])
176176
self.assertEqual(['x(1)'], stru.constraints.keys())
177-
self.failUnless(cns is stru.constraints.values()[0])
177+
self.assertTrue(cns is stru.constraints.values()[0])
178178
stru.deleteAtoms([0])
179179
self.assertEqual({}, stru.constraints)
180180
return

src/diffpy/pdfgui/tests/TestPDFDataSet.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ def test_read(self):
6868
# drobs are all zero
6969
self.assertEqual(npts*[0.0], self.pdfds.drobs)
7070
# dGobs should be defined
71-
self.failUnless(min(self.pdfds.dGobs) > 0)
71+
self.assertTrue(min(self.pdfds.dGobs) > 0)
7272
# x-ray data ---------------------------------------------------
7373
fx_Ni = datafile('Ni_2-8.chi.gr')
7474
self.pdfds.read(fx_Ni)
@@ -80,7 +80,7 @@ def test_read(self):
8080
# drobs are all zero
8181
self.assertEqual(npts*[0.0], self.pdfds.drobs)
8282
# dGobs should be defined
83-
self.failUnless(min(self.pdfds.dGobs) > 0)
83+
self.assertTrue(min(self.pdfds.dGobs) > 0)
8484
return
8585

8686
def test_readStr(self):

src/diffpy/pdfgui/tests/TestPdfFitSandbox.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -231,11 +231,11 @@ def test_alloc(self):
231231
self.assertEqual(1, len(self.box._fits))
232232
self.assertEqual(1, len(self.box._fits[-1].strucs))
233233
self.assertEqual(0, len(self.box._fits[-1].datasets))
234-
self.failUnless(isinstance(self.box._fits[-1], Fitting))
234+
self.assertTrue(isinstance(self.box._fits[-1], Fitting))
235235
exec "alloc(N, 37.0, 0.07, 0.01, 10.0, 1000)" in sandbox
236236
self.assertEqual(1, len(self.box._fits))
237237
self.assertEqual(1, len(self.box._fits[-1].strucs))
238-
self.failUnless(isinstance(self.box._fits[-1], Calculation))
238+
self.assertTrue(isinstance(self.box._fits[-1], Calculation))
239239
c = self.box._fits[-1]
240240
self.assertEqual(37.0, c.qmax)
241241
self.assertEqual(0.07, c.qdamp)
@@ -257,7 +257,7 @@ def test_calc(self):
257257
exec "alloc(N, 37.0, 0.07, 0.01, 10.0, 1000)" in sandbox
258258
self.assertEqual(1, len(self.box._fits))
259259
exec "calc()" in sandbox
260-
self.failUnless(isinstance(self.box._fits[0], Calculation))
260+
self.assertTrue(isinstance(self.box._fits[0], Calculation))
261261
self.assertEqual(2, len(self.box._fits))
262262
self.assertEqual(0, len(self.box._fits[-1].datasets))
263263
self.assertEqual(0, len(self.box._fits[-1].strucs))
@@ -385,7 +385,7 @@ def test_constrain(self):
385385
cphase = self.box._fits[-1].strucs[self.box._curphase]
386386
cdataset = self.box._fits[-1].datasets[self.box._curdataset]
387387
self.assertEqual(10, len(cphase.constraints))
388-
self.failUnless('pscale' in cphase.constraints)
388+
self.assertTrue('pscale' in cphase.constraints)
389389
self.assertEqual('@6', cphase.constraints['u11(1)'].formula)
390390
self.assertEqual('@7+0.5', cphase.constraints['x(1)'].formula)
391391
self.assertEqual(2, len(cdataset.constraints))

src/diffpy/pdfgui/tests/TestStructureViewer.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -84,10 +84,10 @@ def test_plot(self):
8484
fs.read(datafile('LaMnO3.stru'))
8585
self.assertRaises(ControlConfigError, sv.plot, fs)
8686
sv.executable = 'does/not/exist'
87-
self.failUnless(None is sv._tmpdir)
87+
self.assertTrue(None is sv._tmpdir)
8888
self.assertEqual(0, sv._plotcount)
8989
self.assertRaises(ControlConfigError, sv.plot, fs)
90-
self.failUnless(os.path.isdir(sv._tmpdir))
90+
self.assertTrue(os.path.isdir(sv._tmpdir))
9191
self.assertEqual(1, sv._plotcount)
9292
return
9393

@@ -103,10 +103,10 @@ def test___del__(self):
103103
fs.read(datafile('LaMnO3.stru'))
104104
self.assertRaises(ControlConfigError, sv.plot, fs)
105105
tmpd = sv._tmpdir
106-
self.failUnless(os.path.isdir(tmpd))
106+
self.assertTrue(os.path.isdir(tmpd))
107107
del sv
108108
gc.collect()
109-
self.failIf(os.path.isdir(tmpd))
109+
self.assertFalse(os.path.isdir(tmpd))
110110
return
111111

112112
# def test__writeTemporaryStructure(self):

0 commit comments

Comments
 (0)