use get_results_dictionary method to get params_dict

Author: cadenmyers13

src/diffpy/srfit/fitbase/fitrecipe.py

@@ -1230,8 +1230,18 @@ def initialize_recipe_with_results(self, results, verbose=True):
             If the input results is not a FitResults object or a path to a
             results file.
         """
-        if hasattr(results, "print_results"):
-            params_dict = utils.get_dict_from_results_object(results)
+        if hasattr(results, "get_results_dictionary"):
+            params_dict = results.get_results_dictionary()
+            metrics_in_dict = [
+                "Residual",
+                "Contributions",
+                "Restraints",
+                "Chi2",
+                "Reduced Chi2",
+                "Rw",
+            ]
+            for metric in metrics_in_dict:
+                params_dict.pop(metric, None)
         elif isinstance(results, (str, Path)):
             params_dict = utils.get_dict_from_results_file(results)
         else:

src/diffpy/srfit/fitbase/fitresults.py

@@ -66,6 +66,14 @@
     new_base="diffpy.srfit.fitbase.FitResults",
 )
 
+initializeRecipe_dep_msg = build_deprecation_message(
+    "diffpy.srfit.fitbase",
+    "initializeRecipe",
+    "FitRecipe.in",
+    removal_version,
+    new_base="diffpy.srfit.fitbase.FitResults",
+)
+
 
 class FitResults(object):
     """Class for processing, presenting and storing results of a fit.
@@ -820,6 +828,7 @@ def resultsDictionary(results):
     return mpairs
 
 
+@deprecated(initializeRecipe_dep_msg)
 def initializeRecipe(recipe, results):
     """Initialize the variables of a recipe from a results file.
 

src/diffpy/srfit/util/inpututils.py

@@ -92,25 +92,4 @@ def get_dict_from_results_file(
     return parsed_results_dict
 
 
-def get_dict_from_results_object(results_object) -> dict[str, float]:
-    """Get a dictionary of parameter names and values from a FitResults
-    object.
-
-    Parameters
-    ----------
-    results_object : FitResults
-        The FitResults object containing the parameter names and values.
-
-    Returns
-    -------
-    params_dict : dict
-        The dictionary where keys are parameter names and values are the
-        corresponding parameter values as floats.
-    """
-    param_names = results_object.varnames
-    param_vals = results_object.varvals
-    params_dict = dict(zip(param_names, param_vals))
-    return params_dict
-
-
 # End of file