Skip to content

Commit 3f285b6

Browse files
committed
fix: refine test code to avoid if logic
1 parent 95138f7 commit 3f285b6

1 file changed

Lines changed: 4 additions & 11 deletions

File tree

tests/test_structure.py

Lines changed: 4 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,6 @@ def test___copy__(self):
122122

123123
def test_add_new_atom(self):
124124
s_lat = Lattice()
125-
other_lat = Lattice()
126125
expected = Structure(lattice=s_lat)
127126

128127
length = len(expected)
@@ -131,26 +130,20 @@ def test_add_new_atom(self):
131130
assert len(expected) == actual
132131

133132
object = expected[-1]
134-
if hasattr(object, "element"):
135-
assert object.element == "C"
136-
if hasattr(object, "xyz"):
137-
assert numpy.allclose(object.xyz, [0.1, 0.2, 0.3])
133+
assert object.element == "C"
134+
assert numpy.allclose(object.xyz, [0.1, 0.2, 0.3])
138135

139136
def test_addNewAtom(self):
140137
s_lat = Lattice()
141-
other_lat = Lattice()
142138
expected = Structure(lattice=s_lat)
143139

144140
length = len(expected)
145141
expected.addNewAtom(atype="C", xyz=[0.1, 0.2, 0.3])
146142
actual = length + 1
147143
assert len(expected) == actual
148-
149144
object = expected[-1]
150-
if hasattr(object, "element"):
151-
assert object.element == "C"
152-
if hasattr(object, "xyz"):
153-
assert numpy.allclose(object.xyz, [0.1, 0.2, 0.3])
145+
assert object.element == "C"
146+
assert numpy.allclose(object.xyz, [0.1, 0.2, 0.3])
154147

155148
def test_assignUniqueLabels(self):
156149
"""Check Structure.assignUniqueLabels()"""

0 commit comments

Comments
 (0)