Avoid warnings on typeid expression site-effects.

Use a local reference as a typeid argument instead of expression.

Author: pavoljuhas

src/tests/TestNoMetaStructureAdapter.hpp

@@ -104,7 +104,8 @@ class TestNoMetaStructureAdapter : public CxxTest::TestSuite
             TS_ASSERT_EQUALS(56, pswtbare1->countSites());
             TS_ASSERT_EQUALS(string("Pb"), pswtbare1->siteAtomType(0));
             TS_ASSERT_EQUALS(string("Ti"), pswtbare1->siteAtomType(55));
-            TS_ASSERT(typeid(NoMetaStructureAdapter) == typeid(*pswtbare1));
+            StructureAdapter& r_pswtbare1 = *pswtbare1;
+            TS_ASSERT(typeid(NoMetaStructureAdapter) == typeid(r_pswtbare1));
         }
 
 };  // class TestNoMetaStructureAdapter

src/tests/TestObjCrystStructureAdapter.hpp

@@ -111,7 +111,8 @@ class TestObjCrystStructureAdapter : public CxxTest::TestSuite
 
         void test_typeid()
         {
-            TS_ASSERT(typeid(CrystalStructureAdapter) == typeid(*m_ni));
+            StructureAdapter& r_ni = *m_ni;
+            TS_ASSERT(typeid(CrystalStructureAdapter) == typeid(r_ni));
         }
 
 
@@ -275,8 +276,9 @@ class TestObjCrystStructureBondGenerator : public CxxTest::TestSuite
 
         void test_typeid()
         {
+            BaseBondGenerator& r_nibnds = *m_nibnds;
             TS_ASSERT(typeid(CrystalStructureBondGenerator) ==
-                    typeid(*m_nibnds));
+                    typeid(r_nibnds));
         }
 
 
@@ -424,7 +426,8 @@ class TestObjCrystMoleculeAdapter : public CxxTest::TestSuite
 
         void test_typeid()
         {
-            TS_ASSERT(typeid(AtomicStructureAdapter) == typeid(*m_c60));
+            StructureAdapter& r_c60 = *m_c60;
+            TS_ASSERT(typeid(AtomicStructureAdapter) == typeid(r_c60));
         }
 
 
@@ -539,7 +542,8 @@ class TestObjCrystMoleculeBondGenerator : public CxxTest::TestSuite
 
         void test_typeid()
         {
-            TS_ASSERT(typeid(BaseBondGenerator) == typeid(*m_c60bnds));
+            BaseBondGenerator& r_c60bnds = *m_c60bnds;
+            TS_ASSERT(typeid(BaseBondGenerator) == typeid(r_c60bnds));
         }
 
 

src/tests/TestPeriodicStructureAdapter.hpp

@@ -106,7 +106,8 @@ class TestPeriodicStructureAdapter : public CxxTest::TestSuite
 
         void test_typeid()
         {
-            TS_ASSERT(typeid(PeriodicStructureAdapter) == typeid(*m_ni));
+            StructureAdapter& r_ni = *m_ni;
+            TS_ASSERT(typeid(PeriodicStructureAdapter) == typeid(r_ni));
         }
 
 
@@ -280,8 +281,9 @@ class TestPeriodicStructureBondGenerator : public CxxTest::TestSuite
 
         void test_typeid()
         {
+            BaseBondGenerator& r_nibnds = *m_nibnds;
             TS_ASSERT(typeid(PeriodicStructureBondGenerator) ==
-                    typeid(*m_nibnds));
+                    typeid(r_nibnds));
         }
 
 

src/tests/TestScatteringFactorTable.hpp

@@ -57,13 +57,17 @@ class TestScatteringFactorTable : public CxxTest::TestSuite
             TS_ASSERT(sfx0.get());
             TS_ASSERT(sfx1.get());
             TS_ASSERT_EQUALS(sfx0->type(), sfx1->type());
-            TS_ASSERT(typeid(*sfx0) == typeid(*sfx1));
+            ScatteringFactorTable& r_sfx0 = *sfx0;
+            ScatteringFactorTable& r_sfx1 = *sfx1;
+            TS_ASSERT(typeid(r_sfx0) == typeid(r_sfx1));
             sfn0 = ScatteringFactorTable::createByType("neutron");
             sfn1 = ScatteringFactorTable::createByType("N");
             TS_ASSERT(sfn0.get());
             TS_ASSERT(sfn1.get());
             TS_ASSERT_EQUALS(sfn0->type(), sfn1->type());
-            TS_ASSERT(typeid(*sfn0) == typeid(*sfn1));
+            ScatteringFactorTable& r_sfn0 = *sfn0;
+            ScatteringFactorTable& r_sfn1 = *sfn1;
+            TS_ASSERT(typeid(r_sfn0) == typeid(r_sfn1));
         }